Use HTML input instead of XUL textbox in messengercompose.xul
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: aleca, Assigned: aleca)
References
Details
Attachments
(1 file, 1 obsolete file)
11.87 KB,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Comment 2•3 years ago
|
||
Comment on attachment 9092269 [details] [diff] [review] 1563121-textbox-html-input.patch Review of attachment 9092269 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/compose/content/messengercompose.xul @@ +2074,5 @@ > <label id="subjectLabel" value="&subject.label;" accesskey="&subject.accesskey;" control="msgSubject"/> > </hbox> > + <hbox flex="1" align="center" class="input-container"> > + <html:input id="msgSubject" > + class="toolbar input-inline" toolbar? would think that should not be there (though it was) ::: mail/themes/osx/mail/compose/messengercompose.css @@ +190,5 @@ > margin-bottom: 4px; > margin-inline-end: 6px; > } > > +html|input#msgSubject { I think it's preferred not to specify type and such for with an id (slightly slower, and unncessary)
Assignee | ||
Comment 3•3 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #2)
html|input#msgSubject {
I think it's preferred not to specify type and such for with an id (slightly
slower, and unncessary)
Without specifying the type the style is not applied.
Do you know why it's happening?
Assignee | ||
Comment 4•3 years ago
|
||
I've been looking and asking around and it seems like it's not possible to style and HTML element inside a XUL file without specifying the element type itself.
I guess we could leave it like that for now, and then remove it once we transition to XHTML files.
Do you have a better solution?
Comment 5•3 years ago
|
||
Not sure if it's a bug or not... (though reading MDN, probably).
Looks like you can remove the default xul namespace in messengercompose.css and then it will work with just the id as selector.
Assignee | ||
Comment 6•3 years ago
|
||
That worked.
Are we sure removing the XUL namespace won't affect the styling of other elements?
Comment 7•3 years ago
|
||
Comment on attachment 9092732 [details] [diff] [review] 1563121-textbox-html-input.patch Review of attachment 9092732 [details] [diff] [review]: ----------------------------------------------------------------- It shouldn't. r=mkmelin
Assignee | ||
Comment 8•3 years ago
|
||
Updated•3 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7c55e731be18
Use HTML input instead of XUL textbox in messengercomposer.xul. r=mkmelin
Updated•3 years ago
|
Description
•