1563121 - Use HTML input instead of XUL textbox in messengercompose.xul

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

https://searchfox.org/comm-central/rev/94d2c771f935e9402ca3d19a43fafeeaa8f0ac4f/mail/components/compose/content/messengercompose.xul

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: 1563121-textbox-html-input.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9092269 [details] [diff] [review]
1563121-textbox-html-input.patch

Review of attachment 9092269 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/compose/content/messengercompose.xul
@@ +2074,5 @@
>                <label id="subjectLabel" value="&subject.label;" accesskey="&subject.accesskey;" control="msgSubject"/>
>              </hbox>
> +            <hbox flex="1" align="center" class="input-container">
> +              <html:input id="msgSubject"
> +                          class="toolbar input-inline"

toolbar? would think that should not be there (though it was)

::: mail/themes/osx/mail/compose/messengercompose.css
@@ +190,5 @@
>    margin-bottom: 4px;
>    margin-inline-end: 6px;
>  }
>  
> +html|input#msgSubject {

I think it's preferred not to specify type and such for with an id (slightly slower, and unncessary)

Comment 3

[Alessandro Castellani [:aleca]]

(In reply to Magnus Melin [:mkmelin] from comment #2)

html|input#msgSubject {

I think it's preferred not to specify type and such for with an id (slightly
slower, and unncessary)

Without specifying the type the style is not applied.
Do you know why it's happening?

Comment 4

[Alessandro Castellani [:aleca]]

I've been looking and asking around and it seems like it's not possible to style and HTML element inside a XUL file without specifying the element type itself.
I guess we could leave it like that for now, and then remove it once we transition to XHTML files.

Do you have a better solution?

Comment 5

[Magnus Melin [:mkmelin]]

Not sure if it's a bug or not... (though reading MDN, probably).
Looks like you can remove the default xul namespace in messengercompose.css and then it will work with just the id as selector.

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: 1563121-textbox-html-input.patch

That worked.
Are we sure removing the XUL namespace won't affect the styling of other elements?

Comment 7

[Magnus Melin [:mkmelin]]

Comment on attachment 9092732 [details] [diff] [review]
1563121-textbox-html-input.patch

Review of attachment 9092732 [details] [diff] [review]:
-----------------------------------------------------------------

It shouldn't. r=mkmelin

Comment 8

[Alessandro Castellani [:aleca]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=95efe31940358df4a6d5660863d10cce6db4e2ad

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7c55e731be18
Use HTML input instead of XUL textbox in messengercomposer.xul. r=mkmelin