Closed Bug 1563125 Opened 1 year ago Closed 5 months ago

Use HTML input instead of XUL textbox in mailViewSetup.xul

Categories

(Thunderbird :: General, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 71.0

People

(Reporter: aleca, Assigned: aleca)

References

Details

Attachments

(1 file, 3 obsolete files)

Assignee: nobody → alessandro
Mentor: alessandro
Attached patch 1563125-textbox-html-input.patch (obsolete) — Splinter Review
Attachment #9087179 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9087179 [details] [diff] [review]
1563125-textbox-html-input.patch

Review of attachment 9087179 [details] [diff] [review]:
-----------------------------------------------------------------

This is the seamonkey file
Attachment #9087179 - Flags: review?(mkmelin+mozilla) → review-
Attached patch 1563125-textbox-html-input.patch (obsolete) — Splinter Review

Argh, sorry about that.
Here's the correct patch.

Attachment #9087179 - Attachment is obsolete: true
Attachment #9090235 - Flags: review?(mkmelin+mozilla)
Status: NEW → ASSIGNED
Comment on attachment 9090235 [details] [diff] [review]
1563125-textbox-html-input.patch

Review of attachment 9090235 [details] [diff] [review]:
-----------------------------------------------------------------

You're only changing the linux css file. There should probably be a shared file for them...

::: mailnews/base/search/content/searchWidgets.js
@@ +703,5 @@
>  
>        if (!this.hasChildNodes()) {
>          this.appendChild(
>            MozXULElement.parseXULToFragment(`
> +        <html:input flex="1" class="search-value-textbox" inherits="disabled"></html:input>

<input> *is* selfclosing in html, so use </>

@@ +722,5 @@
>              <menuitem value="4096" stringTag="forwarded" class="search-value-menuitem"></menuitem>
>              <menuitem value="4" stringTag="flagged" class="search-value-menuitem"></menuitem>
>            </menupopup>
>          </menulist>
> +        <html:input flex="1" class="search-value-textbox" inherits="disabled"></html:input>

here too
Attachment #9090235 - Flags: review?(mkmelin+mozilla) → review-
Attached patch 1563125-textbox-html-input.patch (obsolete) — Splinter Review

I'm importing the shared input-fields.css file so the style is uniform across OSs, and I'm not affecting the dedicated Linux style of the searchDialog.css file.

Also, I rolled back the edit on the filterDialog.css as that one is related to a different section.

Attachment #9090235 - Attachment is obsolete: true
Attachment #9090456 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9090456 [details] [diff] [review]
1563125-textbox-html-input.patch

Review of attachment 9090456 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

::: mail/themes/linux/mail/searchDialog.css
@@ +43,5 @@
>  .search-menulist[unavailable="true"] {
>    color: GrayText;
>  }
>  
> +html|input.search-value-textbox {

looks like you can remove the search-value-textbox class completely (from xul, here and from filterDialog.css)
Attachment #9090456 - Flags: review?(mkmelin+mozilla) → review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2609bc8cf72b
Use HTML input instead of XUL textbox in mailViewSetup.xul. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 71.0
You need to log in before you can comment on or make changes to this bug.