1563162 - remove mitmproxy 2.0.2 support in raptor

Status: RESOLVED FIXED

(Testing :: Raptor, task, P2)

Description

[Florin Strugariu [:Bebe]]

One we are fully migrated to mitm 4.0.4 remove mitm2.0.2 support

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Bug 1563162 - remove mitmproxy 2.0.2 support in raptor

Comment 2

[Florin Strugariu [:Bebe]]

from :tarek

If everything works with 4.0.4 now, I wonder if we should not make it the default value, and keep our migration logic in place.

what I would do is :

make playback_version defaults to 4.0.4 inside the mozproxy code
remove playback_version everywhere in the raptor config files
keep the ability to add that variable, for a future version where we would need to compare
keep the raise Exception("Mitmproxy version is unknown!")

This will allow us to smoothly move to a new version with less impact imho.
In any case, I think the current patch needs to clarify this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb5bbbf04fe8
remove mitmproxy 2.0.2 support in raptor r=tarek

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/fb5bbbf04fe8

Comment 5

[Florin Strugariu [:Bebe]]

== Change summary for alert #22952 (as of Tue, 03 Sep 2019 22:19:28 GMT) ==

Improvements:

15% raptor-tp6m-cnn-geckoview-cold android-hw-p2-8-0-arm7-api-16 pgo 2,063.39 -> 1,745.15
12% raptor-tp6m-cnn-geckoview-cold fcp android-hw-p2-8-0-arm7-api-16 pgo 3,677.38 -> 3,235.42
11% raptor-tp6m-cnn-geckoview-cold loadtime android-hw-p2-8-0-arm7-api-16 pgo 3,431.29 -> 3,052.17
9% raptor-tp6m-cnn-geckoview-cold fcp android-hw-p2-8-0-android-aarch64 pgo 3,759.54 -> 3,405.25

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=22952