Closed Bug 1563180 Opened 4 months ago Closed 3 months ago

Prevent synchronization to be ran in parallel multiple times

Categories

(Firefox :: Remote Settings Client, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: leplatrem, Assigned: leplatrem)

Details

Attachments

(1 file)

If multiple sync happen in parallel, it could lead to race conditions within event listeners.

Currently, this could occur when a push notification while the scheduled timer is already running.

Assignee: nobody → mathieu
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7aa8180f36eb
Prevent synchronization to be ran in parallel multiple times r=glasserc

Backed out changeset 7aa8180f36eb (bug 1563180) for ESlint failure

Backout: https://hg.mozilla.org/integration/autoland/rev/64ef6b0c521c95fc9846e8940633d2aefa7b7df9

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7aa8180f36eb010d9bc027cee7440773ad4fe0a0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255111505&repo=autoland&lineNumber=299

[task 2019-07-06T16:14:47.733Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-07-06T16:14:51.158Z] yarn v^1.16.0 needs to be installed locally.
[task 2019-07-06T16:14:51.158Z] Installing eslint for mach using "/usr/local/bin/node /usr/local/bin/npm install --loglevel=error"...
[task 2019-07-06T16:14:51.158Z]
[task 2019-07-06T16:14:51.158Z] eslint installed successfully!
[task 2019-07-06T16:14:51.158Z]
[task 2019-07-06T16:14:51.158Z] NOTE: Your local eslint binary is at /builds/worker/checkouts/gecko/node_modules/.bin/eslint
[task 2019-07-06T16:14:51.158Z]
[task 2019-07-06T16:36:59.995Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/services/settings/test/unit/test_remote_settings.js:357:20 | Replace (m) with m (prettier/prettier)
[task 2019-07-06T16:36:59.995Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/services/settings/test/unit/test_remote_settings.js:363:6 | Replace messages.includes("main/password-fields?sync?already?running"),?"warning?is?shown?about?sync?already?running" with ?????messages.includes("main/password-fields?sync?already?running"),?????"warning?is?shown?about?sync?already?running"??? (prettier/prettier)
[taskcluster 2019-07-06 16:37:00.669Z] === Task Finished ===
[taskcluster 2019-07-06 16:37:01.516Z] Unsuccessful task run with exit code: 1 completed in 1692.424 seconds

Flags: needinfo?(mathieu)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:leplatrem, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(mathieu)
Pushed by mleplatre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/94d41ff9cde1
Prevent synchronization to be ran in parallel multiple times r=glasserc
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Flags: needinfo?(mathieu)
You need to log in before you can comment on or make changes to this bug.