1563205 - Simulate native key shortcuts with dispatchKeyEvent

Status: RESOLVED WONTFIX

(Remote Protocol :: CDP, task, P3)

Description

[Julian Descottes [:jdescottes]]

We landed a basic implementation of Input::dispatchKeyEvent in Bug 1543142.

We intentionally left out some key combinations that can't be simulated with EventUtils or TextInputProcessor today. It seems to mostly affect native keyshortcuts on linux and osx. The goal of this bug is to add support for those key combinations, ideally in EventUtils.js directly so that all our test automation tools can benefit from it at the same time.

Some resources:

• native key events osx: https://searchfox.org/mozilla-central/source/widget/cocoa/NativeKeyBindings.mm
• native key events linux: https://searchfox.org/mozilla-central/source/widget/gtk/NativeKeyBindings.cpp
• example of a workaround used by :ochameau to implement one of the shortcuts: https://phabricator.services.mozilla.com/D31979

See also the comments from :masayuki in the previous bug:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1543142#c7
• https://bugzilla.mozilla.org/show_bug.cgi?id=1543142#c17

Comment 1

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

The key combinations that most affect the gutenberg suite were added in Bug 1563206. The work in this bug represents a more general solution to the problem, which we don't need for alpha. If specific key bindings end up blocking many gutenberg tests in the near future, I suggest we file bugs for those as they come up.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I don't see that this is needed for Puppeteer examples. When checking those files I cannot see any native key combination.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Native events won't work here because these are not compatible with headless mode. Instead widget events need to be dispatched via the parent process. Given the complexity this will never be done for CDP. For WebDriver BiDi we have bug 1773393.