Closed Bug 1563242 Opened 1 year ago Closed 4 months ago

TelemetryEvent's GetEventRecordsForProcess takes an EventKey but doesn't use it

Categories

(Toolkit :: Telemetry, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: chutten, Assigned: aloknnikhil, Mentored)

Details

(Whiteboard: [good first bug][lang=c++])

Attachments

(1 file)

The function GetEventRecordsForProcess takes a const EventKey& eventKey but doesn't use it.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. The mentor (or someone else) will assign it to you.
  2. Download and build the Firefox source code
    • If you have any problems, please ask on IRC in the #introduction channel. They're there to help you get started.
    • You can also read the Developer Guide, which has answers to most development questions:
  3. Start working on this bug. Remove the function parameter const EventKey& eventKey from GetEventRecordsForProcess in toolkit/components/telemetry/TelemetryEvent.cpp.
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC most hours of most days.
  4. Build your change with mach build and test your change with mach test toolkit/components/telemetry/tests/. Also check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch for review. Mark me as a reviewer so I'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Hi,
I would like to volunteer to help for this bug.

I assigned you the bug. Let me know if anything is unclear or you need further help.

Assignee: nobody → anuragsoni39
Assignee: anuragsoni39 → nobody

I'll pick it up. I have a patch ready that's been tested.

Assignee: nobody → aloknnikhil
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/afd4a2504dc7
TelemetryEvent's GetEventRecordsForProcess takes an EventKey but doesn't use it, r=janerik
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.