Closed Bug 1563264 Opened 7 months ago Closed 7 months ago

Make WebRender qualified algorithm more readable

Categories

(Core :: Graphics: WebRender, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

Even though we have a solution for doing the gradual roll out on 68, I think we should think of what we want to do for future releases. Thoughts?

Flags: needinfo?(kats)

I agree. This is just a first set of patches to make things a bit more readable. I have an idea for a RolloutMatrix class that will allow us to express this in a more table-driven format. Still working out the details and trying to figure out if there's a good way to incorporate the blocklist settings.

Flags: needinfo?(kats)

(In reply to Kartikaya Gupta (email:kats@mozilla.com) (away 17-Jul-2019 to Feb-2020) from comment #5)

I have an idea for a RolloutMatrix class that will allow us to express this in a more table-driven format.

I played around with this and couldn't really get it working out nicely. We have too many dimensions (platform, release channel, graphics vendor, battery, screen size, mesa version) and the table would end up being similarly multi-dimensional and hard to read.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/99faf007b9d9
Add early-exit conditions to reduce nesting; no functional change. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/d74f7bb86aa3
Extract conditions for each graphics vendor; no functional change. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/5edc3595af5c
More early-exits to reduce nesting and maybe increase clarity. r=jrmuizel
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.