1563312 - Needinfo links at top of bug goes to #c0 rather than relevant comment

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[Daniel Veditz [:dveditz]]

One nice feature of the BMO Modal UI was that Needinfos were presented at the top of the bug with the timestamp as a link that took you to the comment where the needinfo was added (or the closest previous comment if the needinfo flag was added separately). The timestamps are still links, but now they always go to the initial description #c0 rather than anything relevant.

Comment 1

[Daniel Veditz [:dveditz]]

I'm not sure this bug will be long enough to demonstrate the difference, but here's a needinfo.

Comment 2

[Daniel Veditz [:dveditz]]

Note the needinfo link uses the anchor #c0 when it should use #c1.

Comment 3

[Kohei Yoshino [:kohei]]

I see. Will keep this ni? and figure out why.

Comment 4

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

This is due to a wrong date comparison between %Y-%m-%d (hyphens) and %Y.%m.%d (dots). Use %Y-%m-%d intensively to solve the issue.

Comment 5

[Kohei Yoshino [:kohei]]

Merged to master.

Comment 7

[Daniel Veditz [:dveditz]]

Yay, thank you!

Comment 8

[Kohei Yoshino [:kohei]]

\o/