Closed Bug 1563351 Opened 5 years ago Closed 5 years ago

Insert search shortcuts into the URL bar with Touch Bar buttons

Categories

(Core :: Widget: Cocoa, enhancement)

Product:
Core
Component:
Widget: Cocoa
Type:
enhancement
Priority:
Not set
Severity:
normal
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Iteration:
71.3 - Sept 30 - Oct 13
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: bugzilla, Assigned: bugzilla)

References

Details

Attachments

(1 file)

Bug 1563351 - Insert search shortcuts into the Urlbar with Touch Bar buttons. r?adw!
47 bytes, text/x-phabricator-request
Details | Review

This should insert different shortcuts into the URL bar as per shorlander's UX spec in 1563347. Note that if there is already a shortcut in the URL bar and a search-shortcut Touch Bar button is pressed, the existing shortcut should be replaced with the new shortcut without replacing the search term.

For example a search for "* coffee" should become "^ coffee" when the History button is pressed.

Type: defect → enhancement
Iteration: 70.1 - Jul 8 - 21 → 70.2 - Jul 22 - Aug 4
Attachment #9079773 - Attachment description: Bug 1563351 - Insert search shortcuts into the Urlbar with Touch Bar buttons. r?mikedeboer! → Bug 1563351 - Insert search shortcuts into the Urlbar with Touch Bar buttons. r?adw!

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:harry, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(htwyford)

The patch in this bug (and in the other patches in this metabug) are blocked by bug 1563349. I spoke to spohl and he hopes to review 1563349 early this week.

Depends on: 1563349
Flags: needinfo?(htwyford)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86ed8b9bee5f
Insert search shortcuts into the Urlbar with Touch Bar buttons. r=adw

https://hg.mozilla.org/mozilla-central/rev/86ed8b9bee5f

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Backed out 8 changesets (Bug 1563350, Bug 1563351, Bug 1563349, Bug 1567939) on suspicion of causing OS X crashes https://bugzilla.mozilla.org/show_bug.cgi?id=1587351 CLOSED TREE a=backout

Flags: needinfo?(htwyford)
Status: RESOLVED → REOPENED
status-firefox71: fixed → ---
Resolution: FIXED → ---
Target Milestone: mozilla71 → ---

I've tracked down the source of the crashes to Part 5 of bug 1563349. A new revision has been r+'d on Phabricator, so I'm clearing needinfo.

Flags: needinfo?(htwyford)
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34d8f3665eea
Insert search shortcuts into the Urlbar with Touch Bar buttons. r=adw

https://hg.mozilla.org/mozilla-central/rev/34d8f3665eea

Status: REOPENED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
Iteration: 70.2 - Jul 22 - Aug 4 → 71.3 - Sept 30 - Oct 13
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: