156336 - Creating folders with user defined characters doesn't work right

Status: RESOLVED FIXED

(MailNews Core :: Internationalization, defect)

Description

[Mike Kaply [:mkaply]]

We're experiencing this problem on OS/2, but looking at the code, it will fail 
elsewhere as well.

Basically, if you create a folder on a Chinese system with a user defined 
character (like FE50 for instance) the create will fail, on OS/2 it hangs 
(which probably happens on other platforms)

This is difficult to fix, because it would require switching mailnews to use 
nsLocalFile instead of filespec to work properly.

My current fix is simply to add an error message and fail gracefully.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Workaround for problem

Display an error message if unicode conversion fails.

Comment 2

[Jessica Blanco]

Attachment: Another workaround for problem

This code takes the hex value of a user defined character and uses that in the
folder name. It will replace characters with their hex value if they're
undefined. It will create the folder, but after restarting the browser you will
no longer see the original name; you will see the name that the folder got
saved as with its hex values.

Using this code will create a folder with a unique name and not cause the
browser to hang, but the folder name will not be exactly as the user wanted it.

Comment 3

[nhottanscp]

I think we can just pop up the alert and let the user to name it differently (so
I prefer the first patch).

Comment 4

[Navin Gupta]

Comment on attachment 90533 [details] [diff] [review]
Workaround for problem

r=naving. I think this is the correct fix because creating w/ some other name
would confuse the user.

Comment 5

[nhottanscp]

Attachment: Merged the patch (attachment 90533) to the trunk.

Comment 6

[nhottanscp]

Comment on attachment 98463 [details] [diff] [review]
Merged the patch (attachment 90533 [details] [diff] [review]) to the trunk.

copy 'r'

Comment 7

[David :Bienvenu]

You need to check with doc people before adding an error message. I'll sr it,
but you need to get approval for the wording before checking in.

Comment 8

[David :Bienvenu]

Comment on attachment 98463 [details] [diff] [review]
Merged the patch (attachment 90533 [details] [diff] [review]) to the trunk.

sr=bienvenu, but get signoff on the error msg wording from Jen or Robin. Thx!

Comment 9

[robinf]

Suggested wording: 

+folderCreationFailed=The folder could not be created because the folder name
you specified contains an unrecognized character. Please enter a different name
and try again.

Comment 10

[nhottanscp]

Attachment: Changed the wording as suggested.

Comment 11

[nhottanscp]

Comment on attachment 98486 [details] [diff] [review]
Changed the wording as suggested.

copy r/sr

Comment 12

[nhottanscp]

checked in to the trunk, thank you mike!