1563405 - Avoid some refcounting in XULContentSinkImpl::ContextStack::Push()

Status: RESOLVED FIXED

(Core :: XUL, task, P3)

Description

[Andrew McCreight [:mccr8]]

In a comment in my part 3 patch for bug 1563066, bz said:

So in OpenRoot, we push on the stack, then add the attributes. But in this code, we add the attributes, then children->AppendElement(), then push on the context stack.
(As a followup?) it might be worth making the order always be "add attributes, then push on the stack" and make the stack-push take an already_AddRefed so we can forget() into it.

AddAttributes has no side effects on |this|, so the reordering is okay. It can't be made static because it calls a method that reads the node info manager field off of |this| or something.

I used RefPtr<>&& instead of already_AddRefed<>, because the ref pointer has to get passed in to the Entry ctor, so you have to use some std::move anyways.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1563405, part 1 - Call AddAttributes earlier in XULContentSinkImpl::OpenRoot().

AddAttributes has no side effects on |this|, so that's okay.

Also remove an extra semi colon.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1563405, part 2 - Use move refs for Push in nsXULContentSink.

This avoids some refcounting.

Also remove a pointless local variable |entry|.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4f406edcb1a
part 1 - Call AddAttributes earlier in XULContentSinkImpl::OpenRoot(). r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/dfe7d3650300
part 2 - Use move refs for Push in nsXULContentSink. r=bzbarsky

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/a4f406edcb1a
https://hg.mozilla.org/mozilla-central/rev/dfe7d3650300