1563435 - Support more new tab page colors

Status: RESOLVED DUPLICATE of bug 1727333

(WebExtensions :: Themes, enhancement, P3)

Description

[Ed Lee :Mardak]

Attachment: example trailhead palette

Bug 1347204 added support for ntp_background and ntp_text. The page already have variables that match up with some webextension colors.ntp_* keys.

Attached is an example of using the new trailhead mozilla color palette:

   "theme": {
      "colors": {
         "ntp_background": [ 217, 191, 255 ],
         "ntp_header": [ 0, 94, 93 ],
         "ntp_link": [ 6, 137, 137 ],
         "ntp_section": [ 255, 214, 178 ],
         "ntp_section_link": [ 0, 96, 224 ],
         "ntp_section_text": [ 205, 61, 0 ],
         "ntp_text": [ 50, 28, 100 ],

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1563435 - Support more new tab page colors

Comment 2

[Dão Gottwald [:dao]]

What's the motivation here? Is there some strong use case or is it more like "just because we can"? This seems like it would make fixing bug 1546540 more tricky. In fact my recommendation for addressing that bug was to implement the dark theme directly in the new tab stylesheet and drop support for ntp_background and ntp_text.

Comment 3

[Ed Lee :Mardak]

Fixing the default theme for system dark theme seems like it should be an independent decision from dropping support of webextension theme colors.

This bug is to better support existing and new webextensions that use these ntp_* colors, some of which Firefox is already handling, to avoid the brokenness of having a mix of default page colors with extension colors by making sure the primary elements on the page are themeable.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Ed Lee :Mardak from comment #3)

Fixing the default theme for system dark theme seems like it should be an independent decision from dropping support of webextension theme colors.

Why should it be independent when the underlying code is in fact not? It seems reasonable to ask if supporting one feature creates problems for another feature and have some sort of plan before going ahead with one of the two.

I believe Chrome supports automatic dark mode as of version 74? How does it handle webext themes and the ntp_ stuff in that mode? Assuming they do something reasonable, how hard would it be for us to do the same based on our new tab page, dark mode, and webext theme implementations? If we can't come up with a plan, it seems like we should decide which feature we consider more important -- supporting (more) ntp_ properties or dark mode.

Comment 5

[Ed Lee :Mardak]

You're suggesting that if we want to support dark mode, we should no longer support users installing webextensions to change the default theme colors on new tab?

ddurst (not sure who to ni? so redirect?), would it be acceptable to drop support of those webextensions?

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Theme colors seem to be a mess, and dark mode is not making this easier to resolve. I think we need to defer this decision until we have agreed on a way to correctly support dark themes. Leaving the needinfo for now, I need to get in touch with the folks working on the dark theme changes.

Comment 7

[Ed Lee :Mardak]

I had a patch from a couple years ago that is probably bitrotten but might be useful for bug 1727333?