Closed Bug 1563450 Opened 4 months ago Closed 4 months ago

Rename Selection methods: AddItem, RemoveItem, AddItemInternal

Categories

(Core :: DOM: Selection, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: mbrodesser, Assigned: mbrodesser)

Details

Attachments

(3 files)

In order to reflect their operations.

Assignee: nobody → mbrodesser
Attachment #9075903 - Attachment description: Bug 1563450: rename `Selection::RemoveItem` to `Selection::RemoveRange`. r=smaug → Bug 1563450: rename `Selection::RemoveItem` to `Selection::RemoveRangeInternal`. r=smaug
Attachment #9075905 - Attachment description: Bug 1563450: rename `Selection::AddItemInternal` to `Selection::IfRangeNotContainedAddItAndTruncateOverlappingRanges`. r=smaug → Bug 1563450: rename `Selection::AddItemInternal` to `Selection::MaybeAddRangeAndTruncateOverlaps`. r=smaug
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f2abecd04b8
rename `Selection::AddItem` to `Selection::AddRangesForSelectableNodes`. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/7912ff94233b
rename `Selection::RemoveItem` to `Selection::RemoveRangeInternal`. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/9342b4491a2d
rename `Selection::AddItemInternal` to `Selection::MaybeAddRangeAndTruncateOverlaps`. r=smaug
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.