1563456 - Let add-ons handle the New Tab color, if Firefox can't provide dark page support.

Status: RESOLVED INVALID

(Firefox :: New Tab Page, enhancement)

Description

[Pranav bhattarai]

Attachment: Screenshot from 2019-07-04 13-58-25.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:67.0) Gecko/20100101 Firefox/67.0
Firefox for Android

Steps to reproduce:

Dark Reader is an open-source browser addon.
It can convert about:newtab white color into Dark/Black because of this dialogue This page is protected by the browser.

Actual results:

Since the native Dark theme option doesn't really convert the new tab color in Ubuntu 19.04 and probably many other distros.

This is the only we users can have, the new tab black.
Save eyes and battery.

Expected results:

As always.

Comment 1

[Jessilyn Davis]

Mardak, can you advise on this?

Comment 2

[Ed Lee :Mardak]

This seems to be the opposite of bug 1546540 where it sounds like the intent there is to not allow add-ons to change the new tab page's colors and make it only follow the default theme "correctly" ?

Comment 3

[Ed Lee :Mardak]

To be clear, webextensions setting theme.colors.ntp_background or ntp_text can change those two page colors already.

Comment 4

[Pranav bhattarai]

(In reply to Ed Lee :Mardak from comment #3)

To be clear, webextensions setting theme.colors.ntp_background or ntp_text can change those two page colors already.

Really, what why it looks like this: https://imgur.com/wXyfst4
Its says: This page (about: new tab) is protected by the browser.

Note: This screenshot is of Chrome because I wanted to show u where is the real issue and Firefox apparently don't allow using OS default Shortkey which is used to take a screenshot when an extension option is active unless u are using Chrome. Weird. And probably another bug which I just found out/noticed.

Comment 5

[Ed Lee :Mardak]

Attachment: extension changing new tab colors

(In reply to Pranav bhattarai from comment #4)

Really, what why it looks like this: https://imgur.com/wXyfst4
Its says: This page (about: new tab) is protected by the browser.

Extensions can say whatever they want. I did a quick search and found this add-on https://addons.mozilla.org/firefox/addon/puregreen which results in the attached screenshot with the extension changing the background to black and some text to green.

Comment 6

[Dão Gottwald [:dao]]

As Ed says add-on themes can set colors for this page, and dark-mode support in Firefox itself is coming, so this bug doesn't seem useful whatever angle you look at it.