Closed
Bug 1563459
Opened 6 years ago
Closed 6 years ago
The patch command is not validating the revision id
Categories
(Conduit :: moz-phab, defect, P2)
Conduit
moz-phab
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1562225
People
(Reporter: zalun, Assigned: zalun)
References
Details
(Keywords: conduit-triaged)
Attachments
(1 obsolete file)
The revision id should be validated and a human-readable error should be returned.
Expected:
$ moz-phab patch -a . https://phabricator.services.mozilla.com/D33819
ERROR: Please use a [D]### to provide the revision id. ("D123" or "123")
Reality:
$ moz-phab patch -a . https://phabricator.services.mozilla.com/D33819
ValueError: invalid literal for int() with base 10: 'https://phabricator.services.mozilla.com/D33819'
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → pzalewa
|
|
Assignee | |
Comment 1•6 years ago
|
||
Keywords: conduit-triaged
i'm going to fix bug 1562225 instead.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
|
||
Updated•6 years ago
|
Attachment #9075913 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•