SyntaxTreesPool.getScriptInfo is unused
Categories
(DevTools :: General, task, P3)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: standard8, Assigned: jdescottes)
References
Details
Attachments
(1 file)
SyntaxTreesPool.getScriptInfo looks to be unused:
https://searchfox.org/mozilla-central/search?q=getScriptInfo&redirect=false
We noticed this as we were investigating it as it appears to have the potential to return a length property that has value -1 which may be unexpected.
|
||
Comment 1•5 years ago
|
||
The priority flag is not set for this bug.
:pbro, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Comment 2•5 years ago
|
||
Julian, Mercurial tells me you are one of the persons who touched this file the most. Do you know where this file is used and why, and whether getScriptInfo can safely be removed?
|
Assignee | |
Comment 3•5 years ago
|
||
I can't see any usage of most of the methods in Parser.jsm either!
Code coverage seems to confirm this.
https://codecov.io/gh/mozilla/gecko-dev/src/master/devtools/shared/Parser.jsm
The function (and file) was added 6 years ago in Bug 762160, but it seems that even then the method was not used.
So I am worried I am missing something.
Since the file seems mostly used for console evaluation (https://searchfox.org/mozilla-central/search?q=Parser.jsm&case=false®exp=false&path=devtools) maybe :nchevobbe knows more?
|
||
Comment 4•5 years ago
|
||
From what I know, and what I've working on, I don't think this is used.
Searching through code seems to validate that.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 6•5 years ago
|
||
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5a40696f0b6 Remove unused getScriptInfo from Parser.jsm r=nchevobbe
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•