Closed
Bug 1563489
Opened 5 years ago
Closed 5 years ago
[BinAST] Make Function parsing more similar to plain JS
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(2 files)
separated from bug 1558604 comment #13.
currently BinAST parser's function handling is very different than plain JS, in term of what object is created/initialized at what timing, and also method name convention.
I'll make it a bit more similar to plain JS, in order to make the change required in bug 1558604 more straightforward.
|
Assignee | |
Updated•5 years ago
|
status-firefox69:
affected → ---
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D36930
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/0b12da4fd972 Part 0: Remove generator related code from BinAST. r=Yoric https://hg.mozilla.org/integration/autoland/rev/ff2f7f88eb44 Part 1: Add BinASTParserPerTokenizer::finish{Eager,Lazy}Function and remove BinASTParserPerTokenizer::buildFunction. r=Yoric,mgaudet
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0b12da4fd972
https://hg.mozilla.org/mozilla-central/rev/ff2f7f88eb44
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•