1563514 - [Windows] Launch profile in new browser opens Profile Manager for non-ascii profiles

Status: VERIFIED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Gabi Cheta [:Gabi] Desktop QA]

• Affected versions
  69.0a1
  68.0esr
  68.0 RC

• Affected platforms
  Windows 7x32
  Windows 10x64

• Unaffected platforms:
  MacOS 10.12
  Ubuntu 18.04

• Steps to reproduce:

1. Launch Firefox with a new profile
2. Go to about:profiles page
3. Click on create new profile option
4. Click Next on the Profile Wizard and enter a non-ascii profile name
5. Click Finish
6. Choose the profile just created and click on "Launch profile in new browser" button

• Expected result:
  Firefox launches with newly created non-ascii characters profile

• Actual result:
  Profile Manager is opened when a non-ascii characters profile is opened with "Launch profile in new browser" button.
  Selecting the non-ascii profile from the Profile Manager launches a new browser.

• Regression range:
  Will find regression asap.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1563514: Use wide strings when launching with a new profile. r=froydnj

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc39e567c3ec
Use wide strings when launching with a new profile. r=mconley

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for build bustages on nsAppStartup.cpp
backout: https://hg.mozilla.org/integration/autoland/rev/186a6109f698f27a959268c246e2a5e98dca3aad

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=bc39e567c3ec89bfcfe74cbf1edacc19ccf03898&group_state=expanded&selectedJob=255502104

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255502104&repo=autoland&lineNumber=20949

task 2019-07-09T15:40:18.710Z] 15:40:18 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/toolkit/components/startup/Unified_cpp_components_startup0.cpp:11:
[task 2019-07-09T15:40:18.710Z] 15:40:18 ERROR - /builds/worker/workspace/build/src/toolkit/components/startup/nsAppStartup.cpp:996:86: error: calling get on a temporary, potentially allowing use after free of the raw pointer
[task 2019-07-09T15:40:18.710Z] 15:40:18 INFO - const char16_t* args[] = {u"-no-remote", u"-P", NS_ConvertUTF8toUTF16(profileName).get()};
[task 2019-07-09T15:40:18.710Z] 15:40:18 INFO - ^
[task 2019-07-09T15:40:18.711Z] 15:40:18 ERROR - /builds/worker/workspace/build/src/toolkit/components/startup/nsAppStartup.cpp:996:86: error: calling get on a temporary, potentially allowing use after free of the raw pointer
[task 2019-07-09T15:40:18.711Z] 15:40:18 INFO - const char16_t* args[] = {u"-no-remote", u"-P", NS_ConvertUTF8toUTF16(profileName).get()};
[task 2019-07-09T15:40:18.711Z] 15:40:18 INFO - ^
[task 2019-07-09T15:40:18.711Z] 15:40:18 INFO - 2 errors generated.
[task 2019-07-09T15:40:18.712Z] 15:40:18 INFO - /builds/worker/workspace/build/src/config/rules.mk:801: recipe for target 'Unified_cpp_components_startup0.o' failed
[task 2019-07-09T15:40:18.712Z] 15:40:18 ERROR - make[4]: *** [Unified_cpp_components_startup0.o] Error 1
[task 2019-07-09T15:40:18.712Z] 15:40:18 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/toolkit/components/startup'
[task 2019-07-09T15:40:18.712Z] 15:40:18 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'toolkit/components/startup/target' failed
[task 2019-07-09T15:40:18.712Z] 15:40:18 ERROR - make[3]: *** [toolkit/components/startup/target] Error 2
[task 2019-07-09T15:40:18.712Z] 15:40:18 INFO - make[3]: *** Waiting for unfinished jobs....

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af369a5fc700
Use wide strings when launching with a new profile. r=mconley

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/af369a5fc700

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider backporting to Beta & ESR68? It grafts cleanly as-landed.

Comment 7

[Dave Townsend [:mossop]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Is this something we should consider backporting to Beta & ESR68? It grafts cleanly as-landed.

You can if you like, but given that this seems to have been broken since Firefox 48 and not reported until now I don't think it is particularly urgent.

Comment 8

[Gabi Cheta [:Gabi] Desktop QA]

Issue is verified as fixed on Windows 10x64 and Windows 7x64 with latest Nightly 70.0a1.