Closed Bug 1563520 Opened 5 years ago Closed 5 years ago

Followup to finish clarifying EbmlComposer

Categories

(Core :: Audio/Video: Recording, task, P3)

69 Branch
task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox69 --- wontfix
firefox70 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

Details

Attachments

(1 file)

This does the following things:

  • Renames mClusters to mCurrentCluster and updates the comment to be accurate.
  • Removes the need for mClusterHeaderIndex since it was always 0.
  • Removes the need for mWritingCluster since it was redundant with
    mCurrentCluster containing something.
  • Renames mClusterLengthLoc to mCurrentClusterLengthLoc to better pair with
    mCurrentCluster.
  • Renames mClusterTimecode to mCurrentClusterTimecode to better pair with
    mCurrentCluster.
  • Reorders member declarations to better reflect which members group together.
  • Fixes static-analysis warnings by removing uint32_t from loop variables.
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: