Closed Bug 1563529 Opened 4 months ago Closed 4 months ago

findbar input box font regression on Windows

Categories

(Toolkit :: Themes, defect, P2)

x86_64
Windows 10
defect

Tracking

()

VERIFIED FIXED
mozilla69
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox67.0.1 --- unaffected
firefox68 --- unaffected
firefox69 --- verified

People

(Reporter: rctgamer3, Assigned: ntim)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

After the findbar was converted from XUL textbox to HTML input (bug 1550559), the font and size of the findbar inputbox have changed from Segoe UI (12px) (in Firefox 68) to the obscure "MS Shell Dlg 2" (13.3333px) (in Firefox 69).

Flags: needinfo?(ntim.bugs)
Attached image findbar68_69.png
Priority: -- → P2

[Tracking Requested - why for this release]:
At a minimum we should figure out why this happened in case it affects all the textboxes that are being migrated.

(In reply to :Gijs (he/him) from comment #2)

[Tracking Requested - why for this release]:
At a minimum we should figure out why this happened in case it affects all the textboxes that are being migrated.

We lost font: inherit:
https://searchfox.org/mozilla-central/rev/11712bd3ce7454923e5931fa92eaf9c01ef35a0a/toolkit/themes/windows/global/textbox.css#31

We should probably apply this to all inputs in global.css.

Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9bfe9db3e7b1
Make HTML inputs inherit font in global.css. r=dao
Assignee: nobody → ntim.bugs
Component: Find Toolbar → Themes
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
Status: RESOLVED → VERIFIED

https://hg.mozilla.org/releases/mozilla-beta/rev/e3099f60b0774651728a6f9a142b6896327b8bd2 on THUNDERBIRD_68_VERBRANCH

We had trouble with html:input formatting in TB 68 beta, hence this uplift.

You need to log in before you can comment on or make changes to this bug.