1563529 - findbar input box font regression on Windows

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P2)

Description

[rctgamer3]

After the findbar was converted from XUL textbox to HTML input (bug 1550559), the font and size of the findbar inputbox have changed from Segoe UI (12px) (in Firefox 68) to the obscure "MS Shell Dlg 2" (13.3333px) (in Firefox 69).

Comment 1

[rctgamer3]

Attachment: findbar68_69.png

Comment 2

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
At a minimum we should figure out why this happened in case it affects all the textboxes that are being migrated.

Comment 3

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #2)

[Tracking Requested - why for this release]:
At a minimum we should figure out why this happened in case it affects all the textboxes that are being migrated.

We lost font: inherit:
https://searchfox.org/mozilla-central/rev/11712bd3ce7454923e5931fa92eaf9c01ef35a0a/toolkit/themes/windows/global/textbox.css#31

We should probably apply this to all inputs in global.css.

Comment 4

[Tim Nguyen :ntim]

Attachment: Bug 1563529 - Make HTML inputs inherit font in global.css. r=dao

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bfe9db3e7b1
Make HTML inputs inherit font in global.css. r=dao

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9bfe9db3e7b1

Comment 7

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-beta/rev/e3099f60b0774651728a6f9a142b6896327b8bd2 on THUNDERBIRD_68_VERBRANCH

We had trouble with html:input formatting in TB 68 beta, hence this uplift.

Comment 8

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/f54da7f15bd40428719e2c79e083ca67f571672e on THUNDERBIRD_68_VERBRANCH

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/mozilla-esr68/rev/fc32651d572e3f3acaaf4bdf03f467c33c44724c on THUNDERBIRD_68_VERBRANCH for >= 68.1