1563559 - Tidy up a few things in SearchService.jsm

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

I was looking through SearchService.jsm and found a few minor things:

• I'd missed removing makeURI/makeChannel when I moved those to SearchUtils.jsm
• We've an observer notification for find-jar-engines that I cannot find any uses of.
• _findEngines is creating the uris array (which isn't uris), and passing it to _parseListJSON which fills them in and then _findEngines returns them. It can simply return the value direct from _parseListJSON.
• There's a couple of cases where we create an intermediate variable to return it straight away.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1563559 - Tidy up a few things in SearchService.jsm. r?daleharvey

• I'd missed removing makeURI/makeChannel when I moved those to SearchUtils.jsm
• We've an observer notification for 'find-jar-engines' that I cannot find any uses of.
• '_findEngines' is creating the 'uris' array (which isn't uris), and passing it to '_parseListJSON' which fills them in and then '_findEngines' returns them. It can simply return the value direct from '_parseListJSON'.
• There's a couple of cases where we create an intermediate variable to return it straight away.

Depends on D36914

Depends on D36914

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af32b84056af
Tidy up a few things in SearchService.jsm. r=daleharvey

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/af32b84056af