Closed Bug 1563633 Opened 1 year ago Closed 1 year ago

OTR, remove LocalizationSync constructor

Categories

(Chat Core :: Security: OTR, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 69

People

(Reporter: aleca, Assigned: KaiE)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

The LocalizationSync constructor was recently removed from the localization.jsm module, therefore is not usable anymore.
https://hg.mozilla.org/mozilla-central/rev/24e366d72108

Currently used in these 3 files: https://searchfox.org/comm-central/search?q=+LocalizationSync&path=

Product: Thunderbird → Chat Core
Version: Trunk → trunk

The replacement may be formatMessagesSync() of Localization object.

Duplicate of this bug: 1563688
Attached patch 1563633-v1.patch (obsolete) — Splinter Review

Please set keyword checkin-needed if you r+. Thanks.

Attachment #9076223 - Flags: review?(alessandro)
Comment on attachment 9076223 [details] [diff] [review]
1563633-v1.patch

Review of attachment 9076223 [details] [diff] [review]:
-----------------------------------------------------------------

Great work!
Attachment #9076223 - Flags: review?(alessandro) → review+
Keywords: checkin-needed
Comment on attachment 9076223 [details] [diff] [review]
1563633-v1.patch

Review of attachment 9076223 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/content/otr-finger.js
@@ +8,1 @@
>    ChromeUtils.import("resource://gre/modules/Localization.jsm", {});

That second argument is obsolete now, right? Not sure how it got here in the first place. You might as well remove it here and everywhere else you touch.
Attached patch 1563633-v1.patchSplinter Review
Attachment #9076223 - Attachment is obsolete: true
Attachment #9076299 - Flags: review+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/8da790400467
Port bug 1558602: Use new API for sync calls to Fluent in OTR chat. r=aleca

Status: NEW → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED

Landed with improved commit message and fixed import calls.

Target Milestone: --- → Instantbird 69

Thanks Jörg, I cannot explain why I had added that {} parameter initially, probably caused by copy/paste from somewhere else.

Component: General → Security: OTR
You need to log in before you can comment on or make changes to this bug.