1563706 - Saying no to patching children still patches children

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Mark Banner (:standard8)]

Running moz-phab patch on a tree with children and saying 'n' still applies all the children:

moz-phab patch --apply-to base D34534
Revision D34534 has child commits.  Would you like to patch the full stack?. (YES/No/Always)? n
Patching revisions: D34532 D34533 D34534 D34535 D34695 D34536 D34696 D35577 D36275 D36989 D35895 D36408 D36040 D36041 D36042 D36045 D36046 D36048 D35950 D35896 D35897 D35898 D35899 D35900 D35951 D35952 D35953 D35954 D35901 D35902 D35903 D36025 D35904 D35905 D35906 D35907 D35908 D35909 D35957 D35927 D35910 D35912 D35913 D35914 D35915 D35916 D35917 D35919 D35920 D35921 D35922 D35923 D35924 D35925 D35926 D35928 D35929 D35930 D35931 D35933 D35934 D35935 D35936 D35938 D35939 D35962 D35963 D36412 D36050 D36052 D36053 D36054 D36055 D36056 D36057 D36058 D36059 D35955 D36202 D35940 D35941 D35942 D35943 D35944 D35945 D35947 D35884 D35885 D35889 D35890 D35891 D35892 D35893 D35894

This should have just been listing the first three commits.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1563706 - Whether or not to patch children should take account of the user's response. r?glob

Comment 2

[Mark Banner (:standard8)]

Piotr, what's the way to push this? I'm guessing I might need someone with permissions?

Comment 3

[Piotr Zalewa [:zalun]]

Hi Mark, I've pushed it just a second ago.

Comment 4

[Piotr Zalewa [:zalun]]

Reopening as tests are still needed

Comment 5

[Mark Banner (:standard8)]

I thought the tests would be handled by bug 1563710?

Comment 6

[Mark Banner (:standard8)]

Seeing as bug 1563710 was raised for the tests, I'll re-close this.