Closed
Bug 1563761
Opened 5 years ago
Closed 5 years ago
JsPropertyProvider's analyzeInput doesn't handle comments
Categories
(DevTools :: Console, defect, P2)
DevTools
Console
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
(Whiteboard: [console-editor])
Attachments
(1 file)
If you have one of the following input:
// do something
fu
/*
* Do something
*/
fu
The autocomplete doesn't appear (it should, with function and Function)
It's because we don't handle comments at all, so / and * are treated as operator, and anything in the comment would be handle like regular JS.
|
Assignee | |
Comment 1•5 years ago
|
||
We weren't handling comments at all, which means that having
any in the console would probably make the autocomplete not
working.
This patch handles both inline and multiline javascript comments,
and adds test cases to ensure we don't regress.
Depends on D36573
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9381b434999b Handle comments in analyzeInput. r=ochameau.
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•