1563920 - Not possible to define filters for news server after bug 1542715

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[:aceman]

In the Filter list dialog, in the top menulist you select for which account/server you want to define filters. For news (NNTP) servers, there is a submenu in which you can select a specific newsgroup on that server or the server itself (to define filters valid for all newsgroups).

The server item is no longer in the list, after bug 1542715.
This regresses functionality and also users can't see/edit the filters they already have defined on the server level.

Comment 1

[:aceman]

If you do not have any newsgroups subscribed for a news server, you can choose the server in the menulist as there is no submenu. But if you have newsgroups, those are shown, but server name is no longer clickable and it is also not offered in the submenu, as before.

Comment 2

[Jorg K (CEST = GMT+2)]

Please address this asap since we're shipping our final beta next week.

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1563920_fixed-news-server-filters.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=72f52c24ec951b43683fea656e2b2f14268e684b

Comment 4

[Jorg K (CEST = GMT+2)]

Thanks, the three content policy failures in the try run are already fixed.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 9076751 [details] [diff] [review]
Bug-1563920_fixed-news-server-filters.patch

Let's not forget this for TB 68 beta, which is now in "release". I'll use the release flag for now to distinguish from TB 69 beta. What a mess.

Comment 6

[:aceman]

Comment on attachment 9076751 [details] [diff] [review]
Bug-1563920_fixed-news-server-filters.patch

Review of attachment 9076751 [details] [diff] [review]:
-----------------------------------------------------------------

Great, thank you.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/566906807461
fixed defining filters for news server. r=aceman

Comment 8

[Jorg K (CEST = GMT+2)]

TB 69 beta (TB 68 beta coming):
https://hg.mozilla.org/releases/comm-beta/rev/1128588a732a5d64cd7dc240536fc43ec9d6af27

Comment 9

[Jorg K (CEST = GMT+2)]

TB 68 beta 5:
https://hg.mozilla.org/releases/comm-beta/rev/45da8935d5bea2df0383a744904028588819dc51