1563947 - [meta] Improve Fullscreen API with native full screen

Status: NEW

(Core :: Widget: Cocoa, enhancement, P2)

Description

[Xidorn Quan [:xidorn] UTC+10]

In bug 1403085, I'm (re)adding the ability to use native macOS full screen mechanism for the Fullscreen API, behind a pref. With that pref enabled, the Fullscreen API would work in a similar way as Chrome on macOS, i.e. immediately enter expand the current window to full screen.

Ideally, we should implement Safari's behavior where the element to full screen expands to the full screen in a separate layer, and the original window keeps working with other tabs usable.

This requires creating a new window to hold the full screen page. I'm not sure what's the best way to do this efficiently under Firefox's architecture.

Comment 1

[Stephen A Pohl [:spohl]]

I'm curious if we should enable this on Nightly to gather feedback. I'm thinking that switching to native full screen in its current form might still constitute an improvement over our current fullscreen implementation and we could then work on improving the transition in a followup bug. What is your opinion?

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

As I'm not actively using macOS for personal use, thus not using fullscreen a lot there, so I'm not sure.

But I'm not against doing that. If you want, I can submit a patch to enable it on nightly for now.

Comment 3

[Stephen A Pohl [:spohl]]

Let's do it! I will keep an eye on incoming bugs.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Filed bug 1631735 for that. Cancelling my ni? here. Will investigate this weekend hopefully.

Comment 6

[Marco Castelluccio [:marco]]

(In reply to Stephen A Pohl [:spohl] from comment #3)

Let's do it! I will keep an eye on incoming bugs.

What's the status of this now that bug 1631735 has been fixed? Should we still consider this S2?

Comment 7

[Gian-Carlo Pascutto [:gcp]]

Adding missing needinfo.

Comment 8

[Stephen A Pohl [:spohl]]

Brad has been working on this and is best positioned to answer this.

Comment 9

[Brad Werth [:bradwerth]]

We probably have working macOS native fullscreen, but we shouldn't close this Bug yet. We are still working through problems with our fullscreen tests in Bug 1826645 and its regressions, and we haven't flipped the pref on by default yet, which is Bug 1802193. Once all those are done, and we've had time to evaluate the user impact of the pref flip, we can call this resolved.