Closed Bug 1563996 Opened 5 years ago Closed 5 years ago

Convert some more VarCache prefs to static prefs

Categories

(Core :: Preferences: Backend, enhancement)

Product:
Core
Component:
Preferences: Backend
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

References

Details

Attachments

(8 files)

Bug 1563996 - Make dom.ipc.cpows.forbid-unsafe-from-browser a static pref. r=sfink
47 bytes, text/x-phabricator-request
Details | Review
Bug 1563996 - Make dom.ipc.cpows.log.{enabled,stack} static prefs. r=sfink
47 bytes, text/x-phabricator-request
Details | Review
Bug 1563996 - Make three VarCache prefs in nsDefaultURIFixup.cpp into static prefs. r=bzbarsky
47 bytes, text/x-phabricator-request
Details | Review
Bug 1563996 - Make browser.xul.error_pages.enabled a static pref. r=bzbarsky
47 bytes, text/x-phabricator-request
Details | Review
Bug 1563996 - Make privacy.trackingprotection.{pbmode.,}enabled static prefs. r=bzbarsky
47 bytes, text/x-phabricator-request
Details | Review
Bug 1563996 - Make consoleservice.logcat a static pref. r=erahm
47 bytes, text/x-phabricator-request
Details | Review
Bug 1563996 - Make layout.show_previous_page a static pref. r=bzbarsky
47 bytes, text/x-phabricator-request
Details | Review
Bug 1563996 - Make dom.ipc.useNativeEventProcessing.content. r=erahm
47 bytes, text/x-phabricator-request
Details | Review

Another brick in the wall for bug 1476820.

Ugh, I meant bug 1448219.

Blocks: 1448219

This is a weird pref.

First, it is VarCached into two different global variables, one in
nsSubDocumentFrame.cpp, and the other in nsView.cpp.

Second, the pref is not defined by default. When the VarCache variables are
initialized they are therefore set to the default value provided to the
AddBoolVarCache() call, which in both cases is true. This semantics isn't
possible with StaticPrefs, so the patch defines the pref as true by default.

Depends on D37203

Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25c1534cc16e
Make dom.ipc.cpows.forbid-unsafe-from-browser a static pref. r=sfink
https://hg.mozilla.org/integration/autoland/rev/71e66aca29eb
Make dom.ipc.cpows.log.{enabled,stack} static prefs. r=sfink
https://hg.mozilla.org/integration/autoland/rev/f05fb375fd16
Make three VarCache prefs in nsDefaultURIFixup.cpp into static prefs. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/a7651a8e30bb
Make browser.xul.error_pages.enabled a static pref. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/9ab78f2ef946
Make privacy.trackingprotection.{pbmode.,}enabled static prefs. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/fb76e4e1d9e0
Make consoleservice.logcat a static pref. r=erahm
https://hg.mozilla.org/integration/autoland/rev/42705dabbde4
Make layout.show_previous_page a static pref. r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/d355305743c0
Make dom.ipc.useNativeEventProcessing.content. r=erahm

Backed out changeset fb76e4e1d9e0 (Bug 1563996) for crashes on consoleservice.logcat.

backout: https://hg.mozilla.org/integration/autoland/rev/05e65f3f2ab4b98de1cbee6365033c9f36d85bdb

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d355305743c09ecd0845d650a701809b3f8cf52a&searchStr=android

failure log e.g.: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=255446464&repo=autoland&lineNumber=1396

[task 2019-07-09T10:25:39.417Z] 10:25:39 WARNING - PROCESS-CRASH | org.mozilla.geckoview.test.AccessibilityTest.testAccessibilityFocus | application crashed [@ mozilla::StaticPrefs::consoleservice_logcat()]
[task 2019-07-09T10:25:39.418Z] 10:25:39 INFO - Crash dump filename: /tmp/tmpaAOW91/4fce3bdb-0ad6-5024-7b82-8c3a2ca40431.dmp
[task 2019-07-09T10:25:39.418Z] 10:25:39 INFO - Operating system: Android
[task 2019-07-09T10:25:39.418Z] 10:25:39 INFO - 0.0.0 Linux 2.6.29-gea477bb #1 Wed Sep 26 11:04:45 PDT 2012 armv7l
[task 2019-07-09T10:25:39.418Z] 10:25:39 INFO - CPU: arm
[task 2019-07-09T10:25:39.418Z] 10:25:39 INFO - ARMv7 ARM Cortex-A8 features: swp,half,thumb,fastmult,vfpv2,edsp,neon,vfpv3
[task 2019-07-09T10:25:39.418Z] 10:25:39 INFO - 1 CPU
[task 2019-07-09T10:25:39.418Z] 10:25:39 INFO - GPU: UNKNOWN
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - Crash reason: SIGSEGV /SEGV_MAPERR
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - Crash address: 0x0
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - Process uptime: not available
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - Thread 34 (crashed)
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - 0 libxul.so!mozilla::StaticPrefs::consoleservice_logcat() [StaticPrefList.h:d355305743c09ecd0845d650a701809b3f8cf52a : 1063 + 0x34]
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - r0 = 0x00000000 r1 = 0x579824a6 r2 = 0x57982451 r3 = 0x0000042c
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - r4 = 0x0000042c r5 = 0x68536100 r6 = 0x00000001 r7 = 0x699405b8
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - r8 = 0x693694f0 r9 = 0x400721f4 r10 = 0x547286cd r12 = 0x00000003
[task 2019-07-09T10:25:39.419Z] 10:25:39 INFO - fp = 0x53de8c4b sp = 0x699405b0 lr = 0x53e08ea1 pc = 0x53e09e50
[task 2019-07-09T10:25:39.420Z] 10:25:39 INFO - Found by: given as instruction pointer in context
[task 2019-07-09T10:25:39.420Z] 10:25:39 INFO - 1 libxul.so!nsConsoleService::LogMessageWithMode(nsIConsoleMessage*, nsConsoleService::OutputMode) [nsConsoleService.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 239 + 0x3]
[task 2019-07-09T10:25:39.420Z] 10:25:39 INFO - r4 = 0x53564e0c r5 = 0x68536100 r6 = 0x00000001 r7 = 0x69940620
[task 2019-07-09T10:25:39.420Z] 10:25:39 INFO - r8 = 0x693694f0 r9 = 0x400721f4 r10 = 0x547286cd fp = 0x53de8c4b
[task 2019-07-09T10:25:39.420Z] 10:25:39 INFO - sp = 0x699405c0 lr = 0x53e09be1 pc = 0x53e09be1
[task 2019-07-09T10:25:39.420Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.421Z] 10:25:39 INFO - 2 libxul.so!nsConsoleService::LogStringMessage(char16_t const*) [nsConsoleService.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 348 + 0x7]
[task 2019-07-09T10:25:39.421Z] 10:25:39 INFO - r4 = 0x53564e0c r5 = 0x400721f4 r6 = 0x693694f0 r7 = 0x69940648
[task 2019-07-09T10:25:39.421Z] 10:25:39 INFO - r8 = 0x69940628 r9 = 0x68536100 r10 = 0x547286cd fp = 0x53de8c4b
[task 2019-07-09T10:25:39.421Z] 10:25:39 INFO - sp = 0x69940628 lr = 0x53e0a06f pc = 0x53e0a06f
[task 2019-07-09T10:25:39.421Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.421Z] 10:25:39 INFO - 3 libxul.so!mozilla::layers::CompositorOGL::Initialize(nsTString<char>) [CompositorOGL.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 506 + 0xb]
[task 2019-07-09T10:25:39.421Z] 10:25:39 INFO - r4 = 0x00020021 r5 = 0x699406c8 r6 = 0x535e48a0 r7 = 0x699408f8
[task 2019-07-09T10:25:39.422Z] 10:25:39 INFO - r8 = 0x69940694 r9 = 0x53dea8f9 r10 = 0x547286cd fp = 0x53de8c4b
[task 2019-07-09T10:25:39.422Z] 10:25:39 INFO - sp = 0x69940650 lr = 0x5477d8a1 pc = 0x5477d8a1
[task 2019-07-09T10:25:39.422Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.422Z] 10:25:39 INFO - 4 libxul.so!mozilla::layers::CompositorBridgeParent::NewCompositor(nsTArray<mozilla::layers::LayersBackend> const&) [CompositorBridgeParent.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 1509 + 0xf]
[task 2019-07-09T10:25:39.422Z] 10:25:39 INFO - r4 = 0x00000000 r5 = 0x69940914 r6 = 0x53564c00 r7 = 0x699409e8
[task 2019-07-09T10:25:39.422Z] 10:25:39 INFO - r8 = 0x69940a98 r9 = 0x69940928 r10 = 0x6994091c fp = 0x69940914
[task 2019-07-09T10:25:39.422Z] 10:25:39 INFO - sp = 0x69940900 lr = 0x5482f63f pc = 0x5482f63f
[task 2019-07-09T10:25:39.423Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.423Z] 10:25:39 INFO - 5 libxul.so!mozilla::layers::CompositorBridgeParent::InitializeLayerManager(nsTArray<mozilla::layers::LayersBackend> const&) [CompositorBridgeParent.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 1429 + 0x9]
[task 2019-07-09T10:25:39.423Z] 10:25:39 INFO - r4 = 0x53564cf8 r5 = 0x53564c00 r6 = 0x699409f8 r7 = 0x69940a18
[task 2019-07-09T10:25:39.423Z] 10:25:39 INFO - r8 = 0x69940a98 r9 = 0x53564cf4 r10 = 0x400721f4 fp = 0x53564c00
[task 2019-07-09T10:25:39.423Z] 10:25:39 INFO - sp = 0x699409f0 lr = 0x5482f4c7 pc = 0x5482f4c7
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - 6 libxul.so!mozilla::layers::CompositorBridgeParent::AllocPLayerTransactionParent(nsTArray<mozilla::layers::LayersBackend> const&, mozilla::layers::LayersId const&) [CompositorBridgeParent.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 1561 + 0x5]
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - r4 = 0x53564c00 r5 = 0x69a668b0 r6 = 0x69a668b4 r7 = 0x69940a40
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - r8 = 0x688112e0 r9 = 0x00000000 r10 = 0x400721f4 fp = 0x53564c00
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - sp = 0x69940a20 lr = 0x5482f7f3 pc = 0x5482f7f3
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - 7 libxul.so!mozilla::layers::PCompositorBridgeParent::OnMessageReceived(IPC::Message const&) [PCompositorBridgeParent.cpp: : 1169 + 0xf]
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - r4 = 0x69940ad0 r5 = 0x69a668b0 r6 = 0x69a668b4 r7 = 0x69940b48
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - r8 = 0x688112e0 r9 = 0x00000000 r10 = 0x400721f4 fp = 0x53564c00
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - sp = 0x69940a48 lr = 0x542e953f pc = 0x542e953f
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - 8 libxul.so!mozilla::layers::PCompositorManagerParent::OnMessageReceived(IPC::Message const&) [PCompositorManagerParent.cpp: : 200 + 0xd]
[task 2019-07-09T10:25:39.426Z] 10:25:39 INFO - r4 = 0x69940ba0 r5 = 0x69a668b0 r6 = 0x00000001 r7 = 0x69940be8
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - r8 = 0x688112e0 r9 = 0x00000000 r10 = 0x535f7ff0 fp = 0x400721f4
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - sp = 0x69940b50 lr = 0x542ed405 pc = 0x542ed405
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - 9 libxul.so!mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy, IPC::Message const&) [MessageChannel.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 2158 + 0xb]
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - r4 = 0x69a668b0 r5 = 0x535f807c r6 = 0x00000001 r7 = 0x69940c08
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - r8 = 0x688112e0 r9 = 0x00000000 r10 = 0x00000000 fp = 0x400721f4
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - sp = 0x69940bf0 lr = 0x54284c9b pc = 0x54284c9b
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - 10 libxul.so!mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) [MessageChannel.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 2082 + 0x7]
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - r4 = 0x535f807c r5 = 0x00000000 r6 = 0x69dd8880 r7 = 0x69940c70
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - r8 = 0xffffffff r9 = 0x535f808c r10 = 0x69a668b0 fp = 0x400721f4
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - sp = 0x69940c10 lr = 0x5428415f pc = 0x5428415f
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - 11 libxul.so!mozilla::ipc::MessageChannel::MessageTask::Run() [MessageChannel.cpp:d355305743c09ecd0845d650a701809b3f8cf52a : 1970 + 0x7]
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - r4 = 0x69a66880 r5 = 0x69dd8880 r6 = 0x69940c88 r7 = 0x69940c80
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - r8 = 0x69940cb8 r9 = 0x69940e10 r10 = 0x69940ce8 fp = 0x000000aa
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - sp = 0x69940c78 lr = 0x54284897 pc = 0x54284897
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - 12 libxul.so!MessageLoop::RunTask(already_AddRefed<nsIRunnable>) [message_loop.cc:d355305743c09ecd0845d650a701809b3f8cf52a : 442 + 0x9]
[task 2019-07-09T10:25:39.427Z] 10:25:39 INFO - r4 = 0x69940e04 r5 = 0x400721f4 r6 = 0x69940c88 r7 = 0x69940cb0
[task 2019-07-09T10:25:39.428Z] 10:25:39 INFO - r8 = 0x69940cb8 r9 = 0x69940e10 r10 = 0x69940ce8 fp = 0x000000aa
[task 2019-07-09T10:25:39.428Z] 10:25:39 INFO - sp = 0x69940c88 lr = 0x542374b7 pc = 0x542374b7
[task 2019-07-09T10:25:39.428Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.428Z] 10:25:39 INFO - 13 libxul.so!MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask&&) [message_loop.cc:d355305743c09ecd0845d650a701809b3f8cf52a : 450 + 0xd]
[task 2019-07-09T10:25:39.428Z] 10:25:39 INFO - r4 = 0x69940e04 r5 = 0x69940cb8 r6 = 0x400721f4 r7 = 0x69940cd0
[task 2019-07-09T10:25:39.428Z] 10:25:39 INFO - r8 = 0x693c1578 r9 = 0x69940e10 r10 = 0x69940ce8 fp = 0x000000aa
[task 2019-07-09T10:25:39.429Z] 10:25:39 INFO - sp = 0x69940cb8 lr = 0x54237879 pc = 0x54237879
[task 2019-07-09T10:25:39.429Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.429Z] 10:25:39 INFO - 14 libxul.so!MessageLoop::DoWork() [message_loop.cc:d355305743c09ecd0845d650a701809b3f8cf52a : 523 + 0x7]
[task 2019-07-09T10:25:39.429Z] 10:25:39 INFO - r4 = 0x69940e04 r5 = 0x00000004 r6 = 0x69940ce0 r7 = 0x69940d18
[task 2019-07-09T10:25:39.429Z] 10:25:39 INFO - r8 = 0x693c1578 r9 = 0x69940e10 r10 = 0x69940ce8 fp = 0x000000aa
[task 2019-07-09T10:25:39.429Z] 10:25:39 INFO - sp = 0x69940cd8 lr = 0x542379cb pc = 0x542379cb
[task 2019-07-09T10:25:39.429Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.430Z] 10:25:39 INFO - 15 libxul.so!base::MessagePumpDefault::Run(base::MessagePump::Delegate*) [message_pump_default.cc:d355305743c09ecd0845d650a701809b3f8cf52a : 35 + 0x7]
[task 2019-07-09T10:25:39.430Z] 10:25:39 INFO - r4 = 0x693e4ec0 r5 = 0x69940e04 r6 = 0x693e4ed0 r7 = 0x69940d90
[task 2019-07-09T10:25:39.430Z] 10:25:39 INFO - r8 = 0x69940d40 r9 = 0x69940d54 r10 = 0x69940d3c fp = 0x00000000
[task 2019-07-09T10:25:39.430Z] 10:25:39 INFO - sp = 0x69940d20 lr = 0x5423820f pc = 0x5423820f
[task 2019-07-09T10:25:39.430Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.430Z] 10:25:39 INFO - 16 libxul.so!MessageLoop::RunInternal() [message_loop.cc:d355305743c09ecd0845d650a701809b3f8cf52a : 315 + 0xf]
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - r4 = 0x69940e04 r5 = 0x400721f4 r6 = 0x69940e04 r7 = 0x69940db8
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - r8 = 0x400721f4 r9 = 0x69901000 r10 = 0x69940f00 fp = 0x2a217170
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - sp = 0x69940d98 lr = 0x54237365 pc = 0x54237365
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - 17 libxul.so!MessageLoop::Run() [message_loop.cc:d355305743c09ecd0845d650a701809b3f8cf52a : 290 + 0x5]
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - r4 = 0x69940e04 r5 = 0x400721f4 r6 = 0x69940e04 r7 = 0x69940de0
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - r8 = 0x400721f4 r9 = 0x69901000 r10 = 0x69940f00 fp = 0x2a217170
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - sp = 0x69940dc0 lr = 0x542372f5 pc = 0x542372f5
[task 2019-07-09T10:25:39.431Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.432Z] 10:25:39 INFO - 18 libxul.so!base::Thread::ThreadMain() [thread.cc:d355305743c09ecd0845d650a701809b3f8cf52a : 192 + 0x5]
[task 2019-07-09T10:25:39.432Z] 10:25:39 INFO - r4 = 0x693e4d60 r5 = 0x693e4d74 r6 = 0x69940e04 r7 = 0x69940ed8
[task 2019-07-09T10:25:39.432Z] 10:25:39 INFO - r8 = 0x400721f4 r9 = 0x69901000 r10 = 0x69940f00 fp = 0x2a217170
[task 2019-07-09T10:25:39.432Z] 10:25:39 INFO - sp = 0x69940de8 lr = 0x5424396d pc = 0x5424396d
[task 2019-07-09T10:25:39.432Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.432Z] 10:25:39 INFO - 19 libxul.so!ThreadFunc(void*) [platform_thread_posix.cc:d355305743c09ecd0845d650a701809b3f8cf52a : 40 + 0x5]
[task 2019-07-09T10:25:39.432Z] 10:25:39 INFO - r4 = 0x69940f00 r5 = 0x2a217170 r6 = 0x5423b839 r7 = 0x69940ee0
[task 2019-07-09T10:25:39.432Z] 10:25:39 INFO - r8 = 0x693e4d68 r9 = 0x69901000 r10 = 0x69940f00 fp = 0x2a217170
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - sp = 0x69940ee0 lr = 0x5423b843 pc = 0x5423b843
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - 20 libc.so + 0xca5a
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - r4 = 0x69940f00 r5 = 0x2a217170 r6 = 0x5423b839 r7 = 0x693e4d60
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - r8 = 0x693e4d68 r9 = 0x69901000 r10 = 0x69940f00 fp = 0x2a217170
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - sp = 0x69940ee8 lr = 0x40033a5c pc = 0x40033a5c
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - Found by: call frame info
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - 21 libc.so + 0xcbd6
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - sp = 0x69940f00 pc = 0x40033bd8
[task 2019-07-09T10:25:39.433Z] 10:25:39 INFO - Found by: stack scanning

Flags: needinfo?(n.nethercote)

I don't understand that crash. The call to StaticPrefs::consoleservice_logcat() is somehow causing a null-pointer crash, but that function doesn't dereference any pointers.

Flags: needinfo?(n.nethercote)

Oh:

Assertion failure: UpdatePolicy::Live == UpdatePolicy::Skip || IsAtomic<bool>::value || NS_IsMainThread() (Non-atomic static pref 'consoleservice.logcat' being accessed on background thread by getter)

The assertion failure is showing up as a null-pointer crash. I just need to change the type from bool to RelaxedAtomicBool.

Assignee: nobody → n.nethercote
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4483006a672e
[Attempt 2] Make consoleservice.logcat a static pref. r=erahm

I re-pushed the backed-out patch directly to mozilla-inbound, because I thought moz-phab and/or Lando might get confused if I tried to use them.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: