Closed Bug 1564078 Opened 1 year ago Closed 1 year ago

GC heap threshold calculation broken by malloc memory tracking changes

Categories

(Core :: JavaScript: GC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 + fixed
firefox70 + fixed

People

(Reporter: jonco, Assigned: jonco)

References

Details

Attachments

(1 file)

The GC help threshold calculation was broken by the malloc memory tracking changes in bug 1395509 comment 33 to ignore the GC invocation kind.

This will need uplift to beta as it affects FF69.

This restores the use of GC invocation kind that was inadvertantly removed by the patch in bug 1395509 comment 33 from the call to ZoneAllocator::updateAllGCThresholds in GCRuntime::endSweepingSweepGroup. Also refactors ZoneMallocThreshold::computeZoneTriggerBytes a little.

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Type: task → defect
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/84bdb98325f0
Fix use of invocation kind that was previously lost and refactor malloc threshold updates r=sfink
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Comment on attachment 9076496 [details]
Bug 1564078 - Fix use of invocation kind that was previously lost and refactor malloc threshold updates r=sfink?

Beta/Release Uplift Approval Request

  • User impact if declined: This fixes a possible memory size regression on beta.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This reverts the behaviour to its previous state before it was changed by bug 1395509.
  • String changes made/needed: None.
Attachment #9076496 - Flags: approval-mozilla-beta?

Comment on attachment 9076496 [details]
Bug 1564078 - Fix use of invocation kind that was previously lost and refactor malloc threshold updates r=sfink?

Fixes a memory usage regression in 69. Approved for 69.0b4.

Attachment #9076496 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.