1564080 - submit button gets disabled after update

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P1)

Description

[Shazada]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

After the last update I opened the website:
https://xential.projecten.contezza.nl/share/page/
There is a login screen
filled in a username test and password test
click on the submit button calles "Sign In"

Actual results:

Nothing happens. No actual submit does take place.
Opening the page in web-developer mode the input button get's disabled.
So before clicking the HTML is:
<button type="button" tabindex="0" id="page_x002e_components_x002e_slingshot-login_x0023_default-submit-button">Sign In</button>
After clicking it get's changed to:
<button type="button" tabindex="0" id="page_x002e_components_x002e_slingshot-login_x0023_default-submit-button" disabled="disabled">Sign In</button>

So after the update disabled="disabled" get's added to the button

Expected results:

Submit should have worked as is and a login request should be made.
This is still the case with the default stable FF 67.0.4.

Comment 1

[Alice0775 White]

regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a9e860d35d5b7074e68e2cd2d50e53cdb69e7523&tochange=ab9d5eeaa90e155f484ae3457aac82fd4d61f8d9

regressed by:ab9d5eeaa90e155f484ae3457aac82fd4d61f8d9 Stone Shih — Bug 1370630 - Untrusted submit event shouldn't trigger form submission; r=smaug

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

@smaug: as Edgar is on PTO, do you know more about this (since you've reviewed the change regressing this)?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

You mean bug 1370630

Comment 4

[Shazada]

I can confirm that the release http://archive.mozilla.org/pub/devedition/releases/68.0b9/
is unaffected.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Bug 1370630 was backed out from Nightly builds already and should be out from 69.0b4 due for release on Friday as well if all goes to plan.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

As bug 1370630 was backed out from nightly, updating status-firefox70.

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1370630#c65 backed out from beta.