Closed Bug 1564118 Opened 3 years ago Closed 3 years ago

Remove the "unwrap_or(OPAQUE_TASK_ADDRESS)" pattern from WebRender

Categories

(Core :: Graphics: WebRender, enhancement, P3)

66 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: kvark, Assigned: kvark)

Details

Attachments

(1 file, 1 obsolete file)

We have about 10 matches for this pattern. The problem here is that get_prim_clip_task_address method returns None when the primitive is completely clipped, which is the opposite semantics to "OPAQUE_TASK_ADDRESS". So we should be either asserting that at the time of this call the value is Some() (relying on earlier stages to exclude the primitive from rendering), or skip the primitive at the spot.

Priority: -- → P3
Assignee: nobody → dmalyshau
Status: NEW → ASSIGNED

those unwrap_or are mostly seen during the batching, where we should asssume that
the primitives are not clipped out and just unwrap() accordingly.

Attachment #9081753 - Attachment is obsolete: true

follow-up to D39940

Attachment #9081753 - Attachment is obsolete: false
Attachment #9082527 - Attachment is obsolete: true
Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5babcd57c494
WR don't assume opaque on the lack of a clip task
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.