1564118 - Remove the "unwrap_or(OPAQUE_TASK_ADDRESS)" pattern from WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Dzmitry Malyshau [:kvark]]

We have about 10 matches for this pattern. The problem here is that get_prim_clip_task_address method returns None when the primitive is completely clipped, which is the opposite semantics to "OPAQUE_TASK_ADDRESS". So we should be either asserting that at the time of this call the value is Some() (relying on earlier stages to exclude the primitive from rendering), or skip the primitive at the spot.

Comment 1

[Dzmitry Malyshau [:kvark]]

Attachment: WR don't assume opaque on the lack of a clip task

those unwrap_or are mostly seen during the batching, where we should asssume that
the primitives are not clipped out and just unwrap() accordingly.

Comment 2

[Dzmitry Malyshau [:kvark]]

Attachment: Fix WR plane splitting clip task address

follow-up to D39940

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5babcd57c494
WR don't assume opaque on the lack of a clip task

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/5babcd57c494