Closed Bug 1564278 Opened 5 years ago Closed 4 years ago

The suggest of Address Bar - Bookmarks shows the base address.

Categories

(Firefox :: Address Bar, defect, P5)

Product:
Firefox
Component:
Address Bar
Version:
67 Branch
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1597791

People

(Reporter: andro.marian.v94, Unassigned)

References

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

I deselect the 'History' and 'Open Tabs' from about:preferences#privacy.

I have in bookmarks the link: https://discordapp.com/channels/@me
Is the only one from the website.

Actual results:

When type in Address Bar: discord
I get two results:
1. https://discordapp.com
2. https://discordapp.com/channels/@me

Expected results:

The 'https://discordapp.com' to not be listened if is not in bookmarks.

Component: General → Address Bar
OS: Unspecified → Windows 10
Hardware: Unspecified → Desktop
Version: unspecified → 67 Branch

I bet the former is an autofilled preselected entry, when you type discord, because discordapp.com is a domain in your bookmarks starting with that word, we autofill it for you, so potentially you can just press Enter to go to it without having to type the full domain. You can just move down to the first result if it's not what you want. This is actually an expected feature.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID

I don't have that domain in bookmarks. I have only 'https://discordapp.com/channels/@me' . Why i want to autocomplete the domain for other link if i don't have that link in bookmarks.

How i disable this?
Add an option to disable this. I don't see the point to add a part of a link if that link does not exists.
If i want an autocomplete for that, i add that link in other Folder / Category.

And i get autocomplete for a https:// automatically if i type a keyword that does not exists or i remove a part of the url.
This is not working good.

https://drive.google.com/open?id=1RKm-yAFwibC949tjAE6ZeZT1Om6kkP7q

The first thing need to be the:

  1. Search on google for:
  2. The domain.
  3. The full address from bookmarks.

An option to disable the domain to be added to autocomplete list.

When using the address bar, suggest: 'Open tabs'.

Is not working without to select the 'Browsing history'.

Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---

(In reply to Andronachi Marian from comment #2)

How i disable this?

it's not possible because it's how it's supposed to work, we autofill up to the next slash. You can only disable the whole autofill feature by setting browser.urlbar.autoFill to false in about:config, but then we won't help you completing inline.

(In reply to Andronachi Marian from comment #3)

And i get autocomplete for a https:// automatically if i type a keyword that does not exists or i remove a part of the url.
This is not working good.

did you set keyword.enabled to false? If so, that is how it is supposed to work, that pref tells that you don't want the browser to figure out if what you typed is a valid url, or reach a search engine if not.
I'm not sure why you get https on "youtube", it sounds like a network problem, you can check what happens using the Network tab in devtools... I suspect there's a proxy or an antivirus or a dns intercepting some traffic, the urlbar is just sending a request to "youtube". But the only way to know is checking the network traffic.

(In reply to Andronachi Marian from comment #5)

When using the address bar, suggest: 'Open tabs'.
Is not working without to select the 'Browsing history'.

This is bug 1477895.

I'll keep this open to answer your questions, but for now it's still a wontfix.

Thanks Marco. I looked but somehow didn't see this one.

I get why the current behavior seems appealing, but let me argue why the current address bar doesn't provide a great user experience.

Suppose I've got the following three bookmarks:

If I type "xk", the first, highlighted result is the bookmark I want. Pressing down and then enter will do a search for "xk"

If I type "stack", the first, highlighted result is "stackoverflow.com". Pressing down and then enter will take me to the bookmarked page I wanted to visit.

Finally, if I type "moz", the first, highlighted result is a search. Pressing down and then enter will take me to the bookmark I wanted.

So three different bookmarks with three different behaviors. When opening a bookmark, I need to stop and look at the results to figure out what keypresses I need, and if I get hasty, it's easy for muscle memory to guide me to the wrong page.

Compare with the experience on desktop: If I type [win]+"firef"+[enter] on windows, it will launch Firefox. If I type [win]+p+"firef" +[enter] on my linux desktop with xmonad, it will launch firefox. Or, if there's a name conflict, usually a few extra characters will disambiguate things.

You say this is a wontfix. Is that just a lack of developer resources? I'm not familiar with the codebase, but I'd be up for making a PR which adds an option to remove that base address from the results, if that would be considered. (It seems like it might not be possible to write an add-on for this, unless I'm mistaken?) But I also understand if that feature isn't considered desirable enough to justify the bloat.

(In reply to Harris Enniss from comment #8)

So three different bookmarks with three different behaviors. When opening a bookmark, I need to stop and look at the results to figure out what keypresses I need, and if I get hasty, it's easy for muscle memory to guide me to the wrong page.

I think you just can't get comfortable with how the autofill feature works. Autofill is supposed to complete a domain when you type the initial part of it, like a shell completing a command. it is not supposed to complete in the middle. So yes "xk" will go to "xkcd.com" and "stack" goes to "stackoverflow.com". This always happened from Firefox 3.0 on. Before that time, we used to have an "autocomplete in the middle" feature for your third case, but it was ugly and unreadable, users didn't like it.
The feature is intended to help users complete domains when they start typing the initial part of them, for your third case you should type "bug".
It also has a sub-feature where for things like visiting reddit.com/r/firefox you could potentially just type "r -> r -> f", how you would do in a shell autocomplete.
As I said, you can already disable this feature by setting browser.ulrbar.autoFill to false.
There is around a bug about allowing it to complete full urls rather than domains, but still always starting from the beginning, not the middle.

Compare with the experience on desktop: If I type [win]+"firef"+[enter] on windows, it will launch Firefox. If I type [win]+p+"firef" +[enter] on my linux desktop with xmonad, it will launch firefox. Or, if there's a name conflict, usually a few extra characters will disambiguate things.

If you type "fox", does it work? On my system it doesn't, but it works if you type the beginning "fire", it's about the same thing, it just completes things starting with what you type.

You say this is a wontfix. Is that just a lack of developer resources?

Partially, but it's mostly about the fact some time ago we decided this is the kind of experience we wanted. To change it, we'd need more than a couple bug reports, we need clear evidence this is a problem affecting most users, and that alternatives may be better. Then we'd need someone with UX experience to sit down and brainstorm about a better experience, then evaluate that in a user-study, and finally create a mock-up to discuss with engineering. In practice, because we are limited in resources, we must be sure we don't waste time on thing with low benefits, that requires more evidence of problems in the wild.

But how hard is to add an option to disable this for users that don't like this. For my is annoying to add an extra line that i don't have a choice for it.
Am i am not the only one.

it depends on the exact request, what would the option do exactly?
Options are not considered cheap, because they require additional maintenance, and there's already an option to disable autofill. If your option would just hide the first row, there are alternative ways to do that (userchrome.css).

To be fixed.

  1. When the 'about:preferences#privacy-> 'Address Bar' have the only Bookmarks only checked.

    • Don't add the domain name of the website if is not in bookmarks.

  2. When the show google suggestions is on, this in broken.

    • Should be the second result in the list. Or let users to choice to be to top or bottom.

The priority flag is not set for this bug.
:adw, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(adw)

There are a few different issues reported here. It looks like the main one is that autofill doesn't complete full URLs at first, only domains. I thought we had a bug on that, but I can't find it...

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(adw)
Priority: -- → P5

I'm going to dupe this to bug 1597791, which is the autofill-URLs bug. There are some other things described in this bug but that seems to be the main thing. If you have other bug reports, please file a separate bug for each of them. We can't keep track of many things in one bug.

Status: NEW → RESOLVED
Closed: 5 years ago → 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.