Closed Bug 1564285 Opened 3 months ago Closed 3 months ago

notifications api should use private browsing flags.

Categories

(WebExtensions :: General, defect, P1)

defect

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: mixedpuppy, Assigned: robwu)

Details

Attachments

(1 file)

Assignee: nobody → rob
Status: NEW → ASSIGNED

Besides fixing the "privateBrowsing" flag, this patch also ensures that
notifications are correctly erased if they were closed during the call
into nsIAlertsService, because nsIAlertsService.idl documents that the
"alertfinished" callback may be called immediately.

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task
Type: task → defect
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/ada68809c4c9
Set privateBrowsing flag on extension notifications r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Can you please provide some steps to manually verify this issue? If no manual testing is needed please mark this bug as "qe-verify-"

Flags: needinfo?(rob)

Covered by unit tests. The parent bug (bug 1559697) does need QA, but there is already a qe-verify+ on that (https://bugzilla.mozilla.org/show_bug.cgi?id=1559697#c12).

Flags: needinfo?(rob) → qe-verify-
You need to log in before you can comment on or make changes to this bug.