Closed Bug 1564294 Opened 4 months ago Closed 3 months ago

Disabling a FileLink provider extension with two accounts shows only one account removed

Categories

(Thunderbird :: FileLink, defect)

defect
Not set

Tracking

(thunderbird68 fixed, thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird68 --- fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file)

We're removing things from a collection as we iterate it. That's not clever.

Attachment #9076696 - Flags: review?(richard.marti)
Attachment #9076696 - Flags: approval-comm-esr68?
Attachment #9076696 - Flags: approval-comm-beta?
Comment on attachment 9076696 [details] [diff] [review]
1564294-filelink-iter-1.diff

Thanks.
Attachment #9076696 - Flags: review?(richard.marti) → review+
Keywords: checkin-needed
Comment on attachment 9076696 [details] [diff] [review]
1564294-filelink-iter-1.diff

I'll merge the beta stuff to esr68 in one hit.
Attachment #9076696 - Flags: approval-comm-release+
Attachment #9076696 - Flags: approval-comm-esr68?
Attachment #9076696 - Flags: approval-comm-beta?
Attachment #9076696 - Flags: approval-comm-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fcdc12d8804e
Don't iterate over a live list of FileLink accounts when removing a provider. r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0
Attachment #9076696 - Flags: approval-comm-release+
You need to log in before you can comment on or make changes to this bug.