1564337 - Consider renaming BaselineCompiler.cpp/h to BaselineCodeGen.cpp/h

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

Now that we have both JIT and interpreter code there, using the name of the shared base class, BaselineCodeGen<>, might make more sense.

Comment 1

[Ted Campbell [:tcampbell]]

+1. I think this is a good idea.

Comment 2

[Ted Campbell [:tcampbell]]

Here is summary of what is in BaselineCompiler.cpp right now if anyone has thoughts on the organization of files.

BaselineCodeGen<Handler>

BaselineCompiler
BaselineCompilerHandler
BaselineCompilerCodeGen

BaselineInterpreterGenerator
BaselineInterpreterHandler
BaselineInterpreterCodeGen

JitRuntime::generateDebugTrapHandler

static ComputeAddressOfLocal
static EmitCallFrameIsDebuggeeCheck
static LoadAliasedVarEnv
static LoadBaselineScriptResumeEntries
static LoadInlineValueOperand
static LoadInt32Operand
static LoadInt32OperandSignExtendToPtr
static LoadInt8Operand
static LoadUint16Operand
static LoadUint24Operand
static LoadUint8Operand
static MaybeIncrementCodeCoverageCounter
static LoadBytecodePC
static GetScriptGCThing

constexpr InterpreterPCRegAtDispatch
constexpr HasInterpreterPCReg
constexpr TableSwitchOpFirstResumeIndexOffset
constexpr TableSwitchOpHighOffset
constexpr TableSwitchOpLowOffset

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1564337 - Rename BaselineCompiler.cpp/h to BaselineCodeGen.cpp/h. r?djvj!

Now that BaselineInterpreterGenerator is also defined there, it's nicer to use the
name of the shared base class.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1487d7146b50
Rename BaselineCompiler.cpp/h to BaselineCodeGen.cpp/h. r=djvj

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/1487d7146b50