Open Bug 1564415 Opened 3 months ago Updated 3 months ago

Add-on "Download Star" is harmed by incompatibility


(Firefox :: Extension Compatibility, defect)

67 Branch
Not set





(Reporter: euthanasia_waltz, Unassigned)


"Download Star" add-on( uses api.
It works fine if extensions.webextensions.ExtensionStorageIDB.enabled is false.
However, it doesn't work well if extensions.webextensions.ExtensionStorageIDB.enabled is true.

Steps To Reproduce:

  1. Install "Download Star" add-on(
  2. Go to add-on's preference("Download Star Options"), check "Immediately save changes to controls in the popup"
  3. Click toolbar button of the add-on to open popup
  4. Check any items in "Built-in Filters"
  5. Close the popup and reopen it

Checked items are still checked.

Only "Image" is checked. (it is default settings)
This is because breaks data, so next get() returns empty data, then default settings applied.

Broken data: vm.filters
Initialized at

MediaFilters.forEach(filter => {
 Object.defineProperty(vm.filters, filter.type, {
   enumerable: true,
   get: () => filter.enabled,
   set: value => filter.enabled = value

Saving code:

Loading code:

(I know

Some of these unsupported types will restore as an empty object

Test code to omit culprits: this works

function saveControls () {
 let filters = {};
 for (let key in vm.filters) {
   filters[key] = vm.filters[key];
   controls: vm.controls,
   filters: filters

But this is unnecessary when extensions.webextensions.ExtensionStorageIDB.enabled=false.)

You need to log in before you can comment on or make changes to this bug.