Closed Bug 1564433 Opened 5 months ago Closed 5 months ago

Disable Language Switcher in Developer Edition

Categories

(Firefox :: Preferences, task)

68 Branch
task
Not set

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: flod, Assigned: flod)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The flag currently is enabled behind the flag RELEASE_OR_BETA.

That also includes Developer Edition, and causes bugs like bug 1549085 and bug 1563923.

Scenario:

  • User installs a language pack for Developer Edition 68 mid-cycle. That's possible, because there's a language pack on AMO compatible with 68 (Beta). Note that the language pack doesn't include some features only enabled in DevEdition, and has the wrong branding.
  • User updates to 69. For a week – until the next Beta is released – there are no language packs compatible on AMO with that version, so the language falls back to the language of the build.

The long term fix is language packs compatible with multiple version, but we're far from obtaining that. In the meantime, we should disable the feature for Dev Edition.

Pushed by flodolo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/588f3850b336
Disable Language Switcher in Preferences for Developer Edition r=Callek
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Comment on attachment 9076808 [details]
Bug 1564433 - Disable Language Switcher in Preferences for Developer Edition

Beta/Release Uplift Approval Request

  • User impact if declined: Language switcher is enabled in Developer Edition. This will lead users to install language packs actually designed for Beta, and they will be disabled in the first week of Developer Edition's lifecycle.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changing the default setting for Developer Edition. Nothing changes for other versions (Nightly, Beta, Release)
  • String changes made/needed: --
Attachment #9076808 - Flags: approval-mozilla-beta?

Comment on attachment 9076808 [details]
Bug 1564433 - Disable Language Switcher in Preferences for Developer Edition

DevEdition-only change to avoid causing issues with incompatible language packs during the first week of the cycle. Approved for 69.0b4.

Attachment #9076808 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.