Land initial support for C++ memory allocation tracking
Categories
(Core :: Gecko Profiler, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: gregtatum, Assigned: gregtatum)
References
(Blocks 1 open bug)
Details
Attachments
(8 files, 2 obsolete files)
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
This bug is for the work to sample stacks in the profiler's memory hooks and add them as markers.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Depends on D39882
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D39883
Assignee | ||
Comment 4•5 years ago
|
||
All these patches are WIP.
Assignee | ||
Comment 5•5 years ago
|
||
The previous implementation did not control when the profiler counters
would be destroyed. This could happen while the profiler state was already
locked, or when the lock had already been destroyed. This patch changes
it to be explicit.
Assignee | ||
Comment 6•5 years ago
|
||
Depends on D39882
Assignee | ||
Comment 7•5 years ago
|
||
Depends on D42193
Assignee | ||
Comment 8•5 years ago
|
||
Depends on D42194
Assignee | ||
Comment 9•5 years ago
|
||
Depends on D42195
Assignee | ||
Comment 10•5 years ago
|
||
Depends on D42196
Assignee | ||
Comment 11•5 years ago
|
||
Depends on D42197
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 12•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=56823735e3c663aacaf232ec60443f4f103253d4
Assignee | ||
Comment 13•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=98cb0ed6a9adea9173f51c7ef9dcace748ade93e
Assignee | ||
Comment 14•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce76480687aea010cfa2873d9c36714c1757d8db
Comment 15•5 years ago
|
||
Greg, this looks like a good start, and I have various comments. A chunk of new code of this size and gnarliness will inevitably take a few iterations to get to a landable state :)
Assignee | ||
Comment 16•5 years ago
|
||
Of course! Thanks for the review.
Assignee | ||
Comment 17•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b1ce7ec58e9a3db387573598787bd8de5b4239b
Assignee | ||
Comment 18•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c8a116e3d5bdde640e6d66420b6250c5e86374a
Assignee | ||
Comment 19•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e95b2b0c5cf2a6e55760828acc60a69a2b803de
Assignee | ||
Comment 20•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=44fbfb22344a170492185497b8ec897bd77d4c09
Comment 21•5 years ago
|
||
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32930bba2852 Remove lock failure when removing the profiler counters; r=jesup https://hg.mozilla.org/integration/autoland/rev/2e5fc2937e95 Add a mechanism to block re-entry on profiler memory hooks; r=njn https://hg.mozilla.org/integration/autoland/rev/3987d1690897 Add the ability to collect markers with a Bernoulli trial; r=njn https://hg.mozilla.org/integration/autoland/rev/11edc7e045e3 Disable native allocations when the bloat log is turned on; r=njn https://hg.mozilla.org/integration/autoland/rev/57a891548aca Add a mechanism to collect profiler backtraces; r=njn,gerald https://hg.mozilla.org/integration/autoland/rev/41a47ecc5c8b Only turn on the native allocation tracking with a profiler feature; r=njn https://hg.mozilla.org/integration/autoland/rev/52fa68b8413b Add the native allocations feature to the profiler UI; r=canaltinova https://hg.mozilla.org/integration/autoland/rev/deed0b712be5 Add a native allocation profiling test; r=canaltinova
Comment 22•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/32930bba2852
https://hg.mozilla.org/mozilla-central/rev/2e5fc2937e95
https://hg.mozilla.org/mozilla-central/rev/3987d1690897
https://hg.mozilla.org/mozilla-central/rev/11edc7e045e3
https://hg.mozilla.org/mozilla-central/rev/57a891548aca
https://hg.mozilla.org/mozilla-central/rev/41a47ecc5c8b
https://hg.mozilla.org/mozilla-central/rev/52fa68b8413b
https://hg.mozilla.org/mozilla-central/rev/deed0b712be5
Description
•