1564477 - Cannot re-open window closed using Select All Tabs, Close Tabs

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect, P5)

Description

[jscher2000]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

(Do not test on an important window!)

Selected all tabs in a window (right-click > Select All Tabs) and used right-click > Close Tabs. The entire window closed. (browser.tabs.closeWindowWithLastTab has its default value of true)

Actual results:

Surprisingly, I could not find any way to recover the closed window or any of its tabs. There is no trace of it in recovery.jsonlz4. By the time I realized this, recovery.baklz4 had already lost the window, too.

Expected results:

When an entire window is closed using Select All Tabs, Close Tabs, it should be added to the Recently Closed Windows list.

Comment 1

[Liviu Seplecan]

Hi @jscher2000, let's take one at a time:

• 1st with the option browser.tabs.closeWindowWithLastTab set to "true" -intended behavior is to close the browser when you close all tabs. After reopening the browser accessing from menu bar->History-> Restore Previous Session=> all previously tabs are restored BUT!!! only before opening a new tab.
• 2nd with the option browser.tabs.closeWindowWithLastTab set to "false" - intended behavior in not to close the browser - then accessing Library->History-> Recently Closed Tabs-> at the bottom click on "Restore All Tabs" -as result all the previously accessed tabs will be restored. BUT!!! this will happens only with opening another new tab.
  So, in conclusion, I guess this is the bug.
  Further, I will add a component to it and let someone from dev team to decide what should be the status of this.
  Could be related to: 423552 & 977994
  Thanks.

Comment 2

[jscher2000]

Hi Liviu, I never have fewer than five windows open, so I did not consider what might happen if I performed this procedure on a single open window.

Single Open Window

Choosing Select All Tabs > Close Tabs closes the window and exits Firefox. If I Restore Previous Session, the window is restored with a new tab. All the closed tabs are listed under Recently Closed Tabs. Restore All Tabs takes two tries to actually restore all the tabs. But that is workable. Let's set that aside for purposes of this bug.

Not The Last Window

Choosing Select All Tabs > Close Tabs closes the window. In my other open windows, there is no way to recover the closed window as far as I can tell -- it is not listed on the Recently Closed Windows list, Ctrl+Shift+n does not restore it. Just gone. I would like it to be available on Recently Closed Windows; it's not obvious what tabs should be considered open or closed in that window.

Comment 3

[Liviu Seplecan]

Hi @jscher2000, I've checked again and here are the results:
[Platform affected]: Mac OS X, Ubuntu 18.04, Windows 10
[Environment]: Nightly 70.0a1, beta 69.0b4, release 68.0
=> on all machines and environments the issue occurs with "Select all tabs" involved. I will add a short description:

• open 1st FF window -> open couple of tabs
• open 2nd FF window
• go to 1st FF window and right click on a tab ->Select all tabs->right click again on a tab-> Close tabs
• go to 2nd FF window ->Library->History->Recently Closed Windows => note that is empty.
  *if this scenario in made with simply pressing "X" button instead Selecting all tabs option, the issue won't occur.
  Further, I will mark this issue as "New" - and let dev team to decide about it.

Comment 4

[BugBot [:suhaib / :marco]]

The priority flag is not set for this bug.
:mikedeboer, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Sarah Clements [:sclements]]

Hi, is this still happening for you? We've made recent changes to recently closed tabs and windows so I'm wondering if this is still an issue.

Comment 6

[jscher2000]

Hi Sarah, I can no longer replicate this bug. Great news!