1564568 - Hide What's New toolbar button after the user dismisses the panel

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ricky Rosario [:rrosario, :r1cky]]

Currently, the badging CFR code enables the toolbar button and makes it appear in the toolbar when it is triggered. After the user interacts with the button, the badge goes away but the button stays around. The desired behavior is for the button to also go away.

It would be nice if there was a way to show the user that the panel can still be accessed from the Hamburger menu. Some ideas from UX/Aaron to do this are:

• Have an animation similar to when bookmarks go into the Library toolbar button.
• Badge the Hamburger menu and What's New menu item for some period of time after.
• Something else?
• Intern Project?

At the minimum we need to just hide it. The rest is probably nice to have and doesn't block Skyline.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Aaron said he kind of likes the button lingering around for the browser session after closing the panel. If we go with that, there might not be anything to do here.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5183

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/e7f4a0a4a2e3

Comment 4

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the panel is hidden after it is dismissed (by clicking somewhere else, by clicking on a link inside the panel, and by clicking the toolbar button) on the latest Nightly 70.0a1 (Build ID 20190721215935) on Windows 10, macOS 10.14, and Arch Linux 4.14.3.