ignore differences in inherited, pref-controlled properties for cached scrollbar style assertions
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
From bug 1557857. The text-underline-offset property is pref controlled, and the UA style sheets are currently parsed with that pref disabled. If the pref is enabled later, cached scrollbar part styles can become out of sync with what would normally be computed, since what the all shorthand does not expand to include text-underline-offset, and so we can't prevent text-underline-offset values from inheriting into the scrollbars.
|
Assignee | |
Comment 1•5 years ago
|
||
Per IRC discussion it's probably not worth the effort of trying to make the all shorthand work properly here. Let's just adjust the assertions to allow text-underline-offset to vary, since it has no effect on scrollbar styles.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Now if you add a new inherited, pref-controlled property, you must
declare whether it can have an effect on scrollbar styles. If no,
then the property will be skipped in the assertions that check
whether our cached styles are equal to those we would compute.
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
||
Comment 4•5 years ago
|
||
Bugbug thinks this bug is a enhancement, but please change it back in case of error.
|
|
Assignee | |
Updated•5 years ago
|
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34cb54a3fc37 Ignore pref-controlled properties in cached scrollbar style assertions. r=emilio
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•