Closed Bug 1564597 Opened 7 months ago Closed 7 months ago

ignore differences in inherited, pref-controlled properties for cached scrollbar style assertions

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

From bug 1557857. The text-underline-offset property is pref controlled, and the UA style sheets are currently parsed with that pref disabled. If the pref is enabled later, cached scrollbar part styles can become out of sync with what would normally be computed, since what the all shorthand does not expand to include text-underline-offset, and so we can't prevent text-underline-offset values from inheriting into the scrollbars.

Per IRC discussion it's probably not worth the effort of trying to make the all shorthand work properly here. Let's just adjust the assertions to allow text-underline-offset to vary, since it has no effect on scrollbar styles.

Assignee: nobody → cam
Status: NEW → ASSIGNED

Now if you add a new inherited, pref-controlled property, you must
declare whether it can have an effect on scrollbar styles. If no,
then the property will be skipped in the assertions that check
whether our cached styles are equal to those we would compute.

Summary: all shorthand in UA sheets does include pref-disabled properties, which can trigger cached scrollbar style assertions → ignore differences in inherited, pref-controlled properties for cached scrollbar style assertions

Bugbug thinks this bug is a enhancement, but please change it back in case of error.

Type: defect → enhancement
Type: enhancement → defect
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/34cb54a3fc37
Ignore pref-controlled properties in cached scrollbar style assertions. r=emilio
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.