Closed Bug 1564646 Opened 2 months ago Closed 2 months ago

Don't trigger composites on out-of-viewport image updates

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

Bug 1531898 is for native texture image updates. It seems that it could be extended to external image updates.

Assignee: nobody → sotaro.ikeda.g

Ah, Attachment 9076991 [details] does not work, since external buffer uses resource_cache. Then there is a case that a external image buffer is not counted as active image when picture cache is not updated.
https://searchfox.org/mozilla-central/source/gfx/wr/webrender/src/resource_cache.rs#1569

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → WONTFIX
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---

(In reply to Sotaro Ikeda [:sotaro] from comment #3)

Ah, Attachment 9076991 [details] does not work, since external buffer uses resource_cache. Then there is a case that a external image buffer is not counted as active image when picture cache is not updated.

We need to add image keys of valid tiles.

Depends on: 1565463
Blocks: 1565255
Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5979b492248e
Don't trigger composites on out-of-viewport external image updates r=gw
Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Summary: Don't trigger composites on out-of-viewport external image updates → Don't trigger composites on out-of-viewport image updates
No longer blocks: 1565255
You need to log in before you can comment on or make changes to this bug.