Closed Bug 1564654 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 17533 - [PW] Fix paint worklet canvas clip bound calculation

Categories

(Core :: Web Painting, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17533 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17533
Details from upstream follow.

Xida Chen <xidachen@chromium.org> wrote:

[PW] Fix paint worklet canvas clip bound calculation

Right now when we initialize the paint canvas for paint worklet with a
scale factor or browser zoom, we do not record the zoom factor in the
canvas transform. As a result, when computing the clip bound we will
apply the wrong transformation matrix and thus sometimes the contents
can be completely clipped out while it should not.

This CL fixes the problem and adds a layout test.

Bug: 970783
Change-Id: Ie3709ea5845ca2b405245d4b36f9fe8f99052bad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678287
Reviewed-by: Stephen McGruer \<smcgruer@chromium.org>
Commit-Queue: Xida Chen \<xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#672722}

Component: web-platform-tests → Web Painting
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Type: -- → task
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/f0713e2e434e [wpt PR 17533] - [PW] Fix paint worklet canvas clip bound calculation, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/e3ac966b5768 [wpt PR 17533] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.