Closed Bug 1564663 Opened 3 months ago Closed 3 months ago

Clean up the arguments to document.open

Categories

(Core :: DOM: Core & HTML, task)

task
Not set

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

We should align the names with the spec and remove some comments about them not being used, because they aren't meant to be used.

@bzbarsky: can you please be more specific. Is this about cleaning up FF only, or also the spec? Where should the comments be removed, in FF code and/or the spec?

The spec currently has the "unused" arguments, so FF is implemented according to it.
Or do you mean this issue should be worked on once https://github.com/heycam/webidl/issues/581 (referred to at the spec) is fixed?

Flags: needinfo?(bzbarsky)

Bugbug thinks this bug is a task, but please change it back in case of error.

Type: defect → task

This is about cleaning up our code to match the spec. The "not being used" comments refer to arguments that don't even exist in the spec, not the "existing-but-commented-as-unused" ones. Sorry for the confusion there.

The whole thing is more or less a note to myself; I have a patch that's just waiting on try results at https://treeherder.mozilla.org/#/jobs?repo=try&revision=17b9871d3c2bdfb3f0680bbdd58f25165d20c939

Flags: needinfo?(bzbarsky)
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58288e0f23b9
Clean up the arguments to document.open to align better with the spec.  r=mbrodesser
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.