1564663 - Clean up the arguments to document.open

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Boris Zbarsky [:bzbarsky]]

We should align the names with the spec and remove some comments about them not being used, because they aren't meant to be used.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

@bzbarsky: can you please be more specific. Is this about cleaning up FF only, or also the spec? Where should the comments be removed, in FF code and/or the spec?

The spec currently has the "unused" arguments, so FF is implemented according to it.
Or do you mean this issue should be worked on once https://github.com/heycam/webidl/issues/581 (referred to at the spec) is fixed?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a task, but please change it back in case of error.

Comment 3

[Boris Zbarsky [:bzbarsky]]

This is about cleaning up our code to match the spec. The "not being used" comments refer to arguments that don't even exist in the spec, not the "existing-but-commented-as-unused" ones. Sorry for the confusion there.

The whole thing is more or less a note to myself; I have a patch that's just waiting on try results at https://treeherder.mozilla.org/#/jobs?repo=try&revision=17b9871d3c2bdfb3f0680bbdd58f25165d20c939

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1564663. Clean up the arguments to document.open to align better with the spec. r=mbrodesser

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58288e0f23b9
Clean up the arguments to document.open to align better with the spec.  r=mbrodesser

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/58288e0f23b9