Closed Bug 1564695 Opened 7 years ago Closed 7 years ago

[wpt-sync] Sync PR 17587 - [LayoutNG] Resolve auto inline margins on root.

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17587 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17587
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Resolve auto inline margins on root.

The root HTML element is in a unique situation in LayoutNG, in that its
parent is a regular block container that is laid out by the legacy
engine. In legacy, block container layout expects the children to set
their own margin. Make sure that we do this.

Bug: 978702
Change-Id: I84b8e36bd706e3c01096cd9bd75a0747ddf265ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683973
Reviewed-by: Koji Ishii \<kojii@chromium.org>
Reviewed-by: Ian Kilpatrick \<ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673733}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Type: -- → task
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/332ef9f59f66 [wpt PR 17587] - [LayoutNG] Resolve auto inline margins on root., a=testonly
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.