1564718 - [wpt-sync] Sync PR 17618 - Reland "Insert a generated item after preserved spaces following a forced break"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 17618 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17618
Details from upstream follow.

Javier Fernandez <[e-mail]> wrote:

Reland "Insert a generated item after preserved spaces following a forced break"

This is a reland of 6b0ca8ce33e71d570fce11ae6fb5f898ddf053e4

The root cause of the regression that motivated the revert was that in the
original commit I removed a Failure entry by mistake from the TestExpectations
file.

The removed entry was added precisely for the word-break-break-all-004.html
test only for Mac platforms. This was the test that regressed, since the
original path didn't provide any behavior change affecting the mentioned
test.

So this CL tries to reland the original patch, but restoring the Failure entry
for the word-break-break-all-004.html test in Mac platforms.

Original change's description:

Insert a generated item after preserved spaces following a forced break

We already had to implement a special logic to deal with leading
preserved white spaces due some optimizations we have in the line
breaking code to give always breaking opportunities before spaces.

However, the presence of forced breaks may cause some of the following
spaces becoming leading preserved spaces in the next line.

This patch applies the same logic we had for such leading spaces at
the text's first line. It also needs to define additional cases in the
function that evaluates the need of adding these generated breaking
opportunity items.

Bug: 976195
Change-Id: If39e7ba8a535c15d33d6021c6cd04da9590b1131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667305
Commit-Queue: Javier Fernandez \<[e-mail]>
Reviewed-by: Koji Ishii \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#671656}

TBR=[e-mail]

Bug: 976195
Change-Id: Id55acef369248ec30f5cfa68cbb59051bf7af8f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1683234
Reviewed-by: Javier Fernandez \<[e-mail]>
Commit-Queue: Javier Fernandez \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#674305}

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=981707706a9bf772d01ddf04f5fa7c9980fcb92d

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7cef1106ee8c806c25960b69ae79d2324796d4c0

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Failed to get results from try push

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c600d38b9035
[wpt PR 17618] - Reland "Insert a generated item after preserved spaces following a forced break", a=testonly

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/c600d38b9035