1564763 - 1.3% compiler_metrics num_static_constructors (android-5-0-x86_64) regression on push dd61d5c2a773250956ae723aa592f0e8d85a8f78 (Fri May 31 2019)

Status: RESOLVED WORKSFORME

(Core :: DOM: Copy & Paste and Drag & Drop, defect, P1)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=dd61d5c2a773250956ae723aa592f0e8d85a8f78

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

1% compiler_metrics num_static_constructors android-5-0-x86_64 opt 77.00 -> 78.00

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21788

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Comment 1

[Neil Deakin]

I don't see why that patch would have caused any change to static constructors on Android only.

Is there some way to know what the test thinks was added?

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

I updated the alert summary. There's an alert on linux 64 also, hope it helps.
== Change summary for alert #21788 (as of Wed, 10 Jul 2019 04:11:12 GMT) ==

Regressions:

1% compiler_metrics num_static_constructors android-5-0-x86_64 opt 77.00 -> 78.00
1% compiler_metrics num_static_constructors linux64 opt 100.00 -> 101.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=21788

Comment 3

[Ionuț Goldan [:igoldan]]

(In reply to Neil Deakin from comment #1)

I don't see why that patch would have caused any change to static constructors on Android only.

Is there some way to know what the test thinks was added?

:froydnj could you provide some assistance to Neil in this regard?

Comment 4

[Nathan Froyd [:froydnj]]

I'm guessing Neil's patch just moved how files are accumulated into UNIFIED_SOURCES; I don't see anything in the patch that would result in new static constructors.