1564788 - Dereference after null check in PrintPreviewUserEventSuppressor::HandleEvent(Event*)

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Andi [:andi]]

Our Coverity Static Analysis tool implies that a potential Dereference after null check occurs in PrintPreviewUserEventSuppressor::HandleEvent(Event*) for variable aEvent.

The nullity of the variable is checked here, thus presuming it can be null and it's passed without nullcheck, here, being later on dereferenced.

Maybe it wouldn't hurt that the main condition should also include aEvent.

Comment 1

[Sean Voisen (:svoisen)]

@jwatt: Maybe a small conditional adjustment this in the area I think you've been refactoring recently?

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1564788. Remove unnecessary null check from PrintPreviewUserEventSuppressor::HandleEvent. r=masayuki

Most other overrides of nsIDOMEventListener::HandleEvent don't null check
aEvent at all. This method should never be called without an event.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jwatt, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd6e8cc3c3d4
Remove unnecessary null check from PrintPreviewUserEventSuppressor::HandleEvent. r=masayuki

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/dd6e8cc3c3d4

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dd6e8cc3c3d4