Closed Bug 1564791 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 17644 - Update entryType names to follow conventions

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 17644 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/17644
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

Update entryType names to follow conventions

Currently, we have entryTypes 'firstInput', 'layoutShift', and
'largestContentfulPaint' in experimental code (disabled by default, at
most under Origin Trial). This CL updates the naming to follow the
conventions specified at
https://w3ctag.github.io/design-principles/#casing-rules, so they become
'first-input', 'layout-shift', and 'largest-contentful-paint'.

Bug: 823744, 965505, 581518
Change-Id: I989a59fb62b886ab305b0e0fb4be8f3556c1ca82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685975
Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
Reviewed-by: Timothy Dresser \<tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#674490}

PR 17644 applied with additional changes from upstream: 93ba864d402d941a2670681d535e33723e5296c0, 0a02aa2599f1914a56b8557f29ec579ca5e6e701, f7dbdc0bb7a3566b1b28e1cb49178ba9d71b1bc6, e7a6c3da97d3d7dc831b992d27bbca6963cd1754, 83a739f36b26abff6d2f0ecf27038701072bac6f, 218bb5da6f686abf472c91c4dcfe1c3133487f9d
Type: -- → task
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ffb8dd70309a
[wpt PR 17644] - Update entryType names to follow conventions, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ffb8dd70309a

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in before you can comment on or make changes to this bug.