1564801 - Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections

Status: RESOLVED FIXED

(Firefox :: Protections UI, task, P3)

Description

[Johann Hofmann [:johannh]]

These directories are testing the same thing, we should merge them.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

A good first step here is to just move all the tests from one folder to the other and merge the head.js files, and update the manifests. I'd suggest we keep the siteProtections folder, but I'd be open to a new name.

A second step might be to audit whether we have multiple tests that do the same thing, and/or merge similar tests.

Comment 2

[Obayagbona Uwagbae Alexander]

I was thinking of renaming the folder to "testingUI and siteProtections" and merging the browser.ini and head.js files. I could look through the tests though.
Or should I just merge them all in the "siteProtections" folder? Although that affects the name of the folder.
Which is better?

Comment 3

[Johann Hofmann [:johannh]]

I vote for protectionsUI as a folder name :)

Comment 4

[Obayagbona Uwagbae Alexander]

Attachment: Bug 1564801 - Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI. r=nhnt11

Comment 5

[Obayagbona Uwagbae Alexander]

Attachment: Bug 1564801 - Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI(revisions). r=nhnt11

Comment 6

[Obayagbona Uwagbae Alexander]

Attachment: Bug 1564801 - Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI(revisions-edit). r=nhnt11

Comment 7

[Obayagbona Uwagbae Alexander]

Attachment: Bug 1564801 - Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI(revisions_from_scratch). r=nhnt11

Comment 8

[Obayagbona Uwagbae Alexander]

Attachment: Bug 1564801 - Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI. r=nhnt11

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d384e9731de
Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI. r=nhnt11

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8d384e9731de