Closed Bug 1564801 Opened 1 year ago Closed 7 months ago

Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections

Categories

(Firefox :: Protections UI, task, P3)

66 Branch
task

Tracking

()

RESOLVED FIXED
Firefox 76
Tracking Status
firefox76 --- fixed

People

(Reporter: johannh, Assigned: uwaobayagbona, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 4 obsolete files)

These directories are testing the same thing, we should merge them.

Mentor: nhnt11
No longer blocks: 1600569
Assignee: nobody → uwaobayagbona
Status: NEW → ASSIGNED

A good first step here is to just move all the tests from one folder to the other and merge the head.js files, and update the manifests. I'd suggest we keep the siteProtections folder, but I'd be open to a new name.

A second step might be to audit whether we have multiple tests that do the same thing, and/or merge similar tests.

I was thinking of renaming the folder to "testingUI and siteProtections" and merging the browser.ini and head.js files. I could look through the tests though.
Or should I just merge them all in the "siteProtections" folder? Although that affects the name of the folder.
Which is better?

I vote for protectionsUI as a folder name :)

Attachment #9134583 - Attachment is obsolete: true
Attachment #9134582 - Attachment is obsolete: true
Attachment #9134252 - Attachment is obsolete: true
Attachment #9134592 - Attachment is obsolete: true
Attachment #9135482 - Attachment description: Bug 1564801 - Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI(revisions_from_scratch-edit). r=nhnt11 → Bug 1564801 - Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI. r=nhnt11
Pushed by shindli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d384e9731de
Consolidate b/b/c/test/trackingUI and b/b/c/test/siteProtections into b/b/c/test/protectionsUI. r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
You need to log in before you can comment on or make changes to this bug.