Closed Bug 1564813 Opened 1 year ago Closed 1 year ago

Status bar animation should be disabled by default

Categories

(Thunderbird :: Mail Window Front End, enhancement)

enhancement
Not set

Tracking

(thunderbird68+ fixed, thunderbird69 fixed, thunderbird70 fixed)

RESOLVED FIXED
Thunderbird 70.0
Tracking Status
thunderbird68 + fixed
thunderbird69 --- fixed
thunderbird70 --- fixed

People

(Reporter: laurens, Assigned: Paenglab)

Details

Attachments

(3 files, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Show Status bar

Actual results:

When Status bar is shown there is a constant animation effect of Quota

Expected results:

Don't have distracting animations as a default in a productivity tool like Thunderbird.

Type: defect → enhancement

Can you provide a screenshot of what you mean. Is this the same issue as reported in bug 1564440?

Richard, what's going on here?

Flags: needinfo?(richard.marti)

I don't know what animation is meant. Laurens, is it the undetermined animation or is the quota level always changing? Can you attach a screenshot?

I normally never see the quota as my fill level is too low on my IMAP accounts.

Flags: needinfo?(richard.marti) → needinfo?(laurens)

Highlighted position of animations (bottom right status bar)

Flags: needinfo?(laurens)

Thank Richard, Please find attached.

I think that default for such animations should be off. Almost all modern OS (Win10, macOS, iOS) have settings to reduce these distractions.

You mean progress bars. There should only be one and it never caught my eye on Windows.

Laurens, the left bar is always shown or only during server action (message download/sync etc.)?

Attached patch 1564813-quotaMeter-color.patch (obsolete) — Splinter Review

On Windows the system progressbar is animated, which is distracting when it is always shown. Before the conversion to html:progress we had special rules which didn't apply any more after the conversion. This patch fixes it.

Assignee: nobody → richard.marti
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9078039 - Flags: review?(alessandro)
Attached image QuotaMeter.png

Screenshot that shows how it looks again.

Hmm, should I be seeing this problem in TB 68? How to trigger it?

With Inspector search #quotaPanel. Remove in hidden="true" the true. Now search #quotaMeter and change to value="50" on it. Now you should see it.

And yes, this should be in 68 too.

Comment on attachment 9078039 [details] [diff] [review]
1564813-quotaMeter-color.patch

Review of attachment 9078039 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
r+ after those small visual changes.

::: mail/themes/linux/mail/preferences/preferences.css
@@ +63,2 @@
>    -moz-appearance: none;
> +  background-color: #88aaff;

This colour doesn't look great.
Let's go with `#45a1ff` which is part of our style guide.

@@ +65,1 @@
>    opacity: .5;

Let's bump the opacity to `0.75` to not wash out the blue too much.

::: mail/themes/osx/mail/preferences/preferences.css
@@ +74,5 @@
>  
>  /* Quota meter in Folder Properties */
>  
>  #quotaPercentageBar {
> +  border-color: #8b8b8b;

Same here and all the other instances of this colour.

::: mail/themes/shared/mail/messenger.css
@@ +280,5 @@
> +/* ..... status bar adjustments ..... */
> +
> +#quotaMeter {
> +  min-width: 4em;
> +  max-width: 4em;

4em looks a bit cramped. I'd bump the max-width to 8em.
Attachment #9078039 - Flags: review?(alessandro) → review+

Please put beta-approval? on the next patch.

Changed to #45a1ff .75 opacity and 8em wide.

Attachment #9078039 - Attachment is obsolete: true
Attachment #9078222 - Flags: review+
Attachment #9078222 - Flags: approval-comm-beta?
Keywords: checkin-needed
Target Milestone: --- → Thunderbird 70.0
Comment on attachment 9078222 [details] [diff] [review]
1564813-quotaMeter-color.patch

Thanks.
Attachment #9078222 - Flags: approval-comm-beta? → approval-comm-beta+

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b9aea5202702
Fix the quotaMeter appearance after the html:progress conversion. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.